This repository was archived by the owner on May 30, 2023. It is now read-only.
Stacktraces#270
Closed
jonleighton wants to merge 2 commits into
Closed
Conversation
This is to avoid adding a onError handler to the page that exists in the outer scope.
On reflection, this approach seems like a bad idea and a source of bugs. I think passing object references between pages seems inherently problematic, and we are better off just passing data to the onError handler. If users need the actual object reference, they are able to use try ... catch within the page. This change also means that we are no longer breaking backwards compatibility with the page.onError function signature. WebCore already has a bunch of plumbing to pass around stacks. This exists for the inspector/console. However, we need to actually retrieve the error stack in WebCore::reportException. To achieve this, I am attaching a stackArray property to the error object. This is not as clean as I'd like, but seems ok for now. (We should not document stackArray though.) https://code.google.com/p/phantomjs/issues/detail?id=166
Owner
|
Merged. Thanks! |
Collaborator
|
@ariya You sure you merged this? I can't see the commit anywhere. Jetlag? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see the commit messages for explanation.