Fix capture bugs from Fable 5 scan; consolidate synthetic pcap generators - #4097
Merged
Conversation
…tors - packet.c: session-command throttle never engaged when packetQ >= 75% full - cloud.c: memory leak refreshing AWS credentials every 280s - rules.c: count-field ranges spanning 20+ values never matched - reader-scheme-s3.c: listing stopped early on pages with no matching keys - reader-tpacketv3.c: unchecked PACKET_STATISTICS added garbage stats; %zu fmt - reader-netmap.c: stats always 0, now counted from the RX loop - reader-pcapoverip.c: NULL unref GLib warning when socket creation fails - arp/nbns detail.jade: clicks built nonexistent ip.arp/ip.nbns expressions - adb.c: shell,v2 with parameters not tagged adb:shell-v2 - camel.c: party numbers now decoded as ISUP Q.763 (2 header bytes, odd filler) - certs.c: isCA tested cRLSign instead of keyCertSign; SAN before keyUsage aborted the extension walk - http.c: CONNECT 2xx response now reclassifies the tunnel and skips the fake body (no more md5/sha256 of tunnel bytes); flush counts on unregister - imap.c: CR/LF split across packets left trailing CR, missed end of headers - krb5.c: TCP record length now full 32-bit per RFC 4120 - quic.c: zero-length CHLO tag values no longer stop SNI/VER; drop dead code - rdp.c/s7comm.c: reassembly overflow now tagged+unregistered; s7comm frames clamped to the TPKT boundary - sctp.c: multi-stream interleaved fragments no longer corrupt reassembly - smb.c: SMB1 ByteCount/DialectIndex read as u16; all command cases parse from a message-clamped BSB (no remlen underflow or cross-message strings) - field.c: HASH_COUNT prefix typo; misc comment fixes - tests/gen: one gen_<name>.py per pcap/*synthetic* that regenerates the whole pcap byte-identically; appender scripts merged as section functions - tests/mini-aws.pl: ListObjects now paginates (5 keys) with continuation-token - new regression sessions: certs keyUsage x3, imap CR-split, krb5 big record, quic zero-length tag, s7comm frame clamp, sctp interleave, smb1 dialect0, smb1 malformed delete, adb shell-v2 params Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
License
I confirm that this contribution is made under an Apache 2.0 license and that I have the authority necessary to make this contribution on behalf of its copyright owner.