refactor: use IDs for health prerequisites - #443
Merged
Conversation
- Introduce `DependencyID` and use it for tracking prerequisites - All prerequisites must be fully healthy for a dependant check to trigger Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
Signed-off-by: Bartek Mucha <bartosz.mucha@arm.com>
awphi
approved these changes
Sep 7, 2026
| type failingCheck struct{} | ||
|
|
||
| func (p failingCheck) Run(_ context.Context, _ runner.Runner, _ health.Dependency) (*health.Fix, error) { | ||
| return &health.Fix{Description: "fix me please", Command: "rm -rf /"}, errors.New("very broken") |
Contributor
There was a problem hiding this comment.
Suggested change
| return &health.Fix{Description: "fix me please", Command: "rm -rf /"}, errors.New("very broken") | |
| return &health.Fix{Description: "fix me please", Command: "sudo rm -rf / --no-preserve-root"}, errors.New("very broken") |
In actuality this is a little scary and I worry a confused agent may end up in some bizarre situation may get context polluted by this. Can we do something safer for a test fixture? 😅
Contributor
Author
There was a problem hiding this comment.
That'll teach you to sanbox your agents. 🧌
muchzill4
commented
Sep 7, 2026
Signed-off-by: Bartek Mucha <muchzill4@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Checklist