runner-clean: drop "Register qemu binfmt handlers" step - #35
Merged
Conversation
This per-job step tried to keep qemu-user current via apt so cross-arch
(amd64 host -> arm64 target) rootfs postinsts could run under
qemu-aarch64-static. In practice it did not work and is being removed:
- It cannot fix the real failure. The distro qemu is frozen too old for
newer guests (Ubuntu noble ships qemu 8.2.2), so the header-deb `tar`
postinst dies with "tar: ... Cannot open: Function not implemented".
`apt-get --only-upgrade` is a no-op against that ("already the newest
version").
- It is redundant with the build. lib/functions/rootfs/qemu-static.sh
(prepare_host_binfmt_qemu_cross) already mounts binfmt_misc and runs
`update-binfmts --enable` itself, as long as the package is installed.
- It is noisy and racy. Running apt on every job loses the dpkg lock to
concurrent apt ("Could not get lock ... held by process ..."), and the
`|| true` swallowed the failure, giving false confidence.
qemu/binfmt is instead handled at the host level: build hosts are being
bumped to a newer release (resolute), which brings a current qemu able to
emulate the guest, and provisioning installs qemu-user-static +
binfmt-support. The build re-enables the handlers per run.
Signed-off-by: Igor Pecovnik <igor@armbian.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
Register qemu binfmt handlersstep fromrunner-clean/action.yml.Why
The step ran on every job to keep qemu-user current via apt so cross-arch (amd64 host → arm64 target) rootfs postinsts could run under
qemu-aarch64-static. It doesn't achieve that and is pure overhead:qemu-user-static 8.2.2, so thelinux-headersdebtarpostinst dies withtar: … Cannot open: Function not implemented.apt-get --only-upgradeis a no-op (already the newest version).lib/functions/rootfs/qemu-static.sh(prepare_host_binfmt_qemu_cross) already mountsbinfmt_miscand runsupdate-binfmts --enableitself, provided the package is installed.Could not get lock … held by process …); the|| truethen swallowed the failure and gave false confidence.Seen in the wild (run 30941608953): 21 image builds failed on exactly this
Function not implementedtar error across the x86 pool.Where it's handled instead
At the host level, not per-job:
qemu-user-static+binfmt-support; the build re-enables the handlers per run.Safety
Current fleet already has
qemu-user-staticinstalled and the build re-registers binfmt each run, so no active runner regresses. YAML validated (yaml.safe_loadOK).