Skip to content

Rename walnut-logo.png to walnutpi-logo.png (512x512) - #381

Closed
TallGuy74 wants to merge 1 commit into
armbian:mainfrom
TallGuy74:walnutpi-logo-rename
Closed

Rename walnut-logo.png to walnutpi-logo.png (512x512)#381
TallGuy74 wants to merge 1 commit into
armbian:mainfrom
TallGuy74:walnutpi-logo-rename

Conversation

@TallGuy74

Copy link
Copy Markdown

Follow-up to #379: the armbian/build Verify assets check derives the vendor logo filename from BOARD_VENDOR="walnutpi", so it expects walnutpi-logo.png — the merged walnut-logo.png is never matched. Renames it and bumps to the documented 512x512. Passes validate-board-assets.sh. Unblocks armbian/build#10341.

The armbian/build asset check derives the logo filename from
BOARD_VENDOR (walnutpi); also bump to the documented 512x512 size.
@github-actions github-actions Bot added the size/small PR with less then 50 lines label Aug 6, 2026
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • board-vendor-logos/walnut-logo.png is excluded by !**/*.png
  • board-vendor-logos/walnutpi-logo.png is excluded by !**/*.png

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 9b236d01-bd61-4f5d-967d-db802dfff4e3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added 08 Milestone: Third quarter release Needs review Seeking for review labels Aug 6, 2026
@TallGuy74

Copy link
Copy Markdown
Author

Withdrawn — simpler fix applied on the build side: BOARD_VENDOR set to "walnut" in the board configs, matching the already-merged walnut-logo.png. (If a 512x512 logo is ever wanted, happy to resubmit just that.)

@TallGuy74 TallGuy74 closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

08 Milestone: Third quarter release Needs review Seeking for review size/small PR with less then 50 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant