generate-armbian-images-json: support UEFI cloud .iso artifacts - #387
Merged
Conversation
The UEFI cloud targets now publish a live .iso (uncompressed) alongside qcow2/vhdx. Teach the download-index generator about it: - extract_file_extension: map a plain .iso to the canonical `iso` extension (previously it fell through to the generic last-token fallback and reported `iso` only by luck / would misreport if wrapped). - strip_img_ext: strip a trailing .iso so parse_image_name recovers the clean variant token (e.g. `minimal`) instead of `minimal.iso`. - REDI variant: give ISOs a distinct `-iso` variant like qcow2's `-qcow2`, so the redirector URL is e.g. https://dl.armbian.com/uefi-arm64/Noble_cloud_minimal-iso Signed-off-by: Igor Pecovnik <igor@armbian.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe image metadata generator now strips Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The UEFI cloud targets (
uefi-arm64/uefi-x86,BRANCH: cloud) now publish a live.iso(uncompressed) alongside qcow2/vhdx. This teaches the download-index generator (scripts/generate-armbian-images-json.sh) to represent it correctly.Three small additions:
extract_file_extension— map a plain.isoto the canonicalisoextension (before this it fell through to the generic last-token fallback).strip_img_ext— strip a trailing.isosoparse_image_namerecovers the clean variant token (minimal) instead ofminimal.iso.-isovariant, mirroring qcow2's-qcow2, so the redirector URL comes out as:The release-asset filter already lets
.isothrough (it only drops.txt/.asc/.sha/.torrent), so no change needed there.Validation
Unit-tested the parsing/URL assembly:
..._uefi-arm64_noble_cloud_..._minimal.isoiso.../uefi-arm64/Noble_cloud_minimal-isoRegression-checked:
.img.qcow2.xz→img.qcow2.xzand.img.xz→img.xzunchanged.bash -nclean.Pairs with the build-side change that produces the ISO (
image-output-iso) and the release-target additions that enable it for the trixie minimal UEFI cloud target.