Skip to content

[Bug]: A blank line needs to be added at the end of the kernel's defconfig file for the custom_kernel_config hook to take effect. #9680

@ackPeng

Description

@ackPeng

What happened?

I have a custom_kernel_config function that uses kernel_config_set_x to set many kernel configuration items. During compilation, I found that several configurations were not being compiled into the .config file. I asked AI to analyze why this was happening, and it pointed out that I needed to add a blank line to linux-rk35xx-vendor.config because the first appended character collided with the no-newline EOF. Following AI's suggestion, I added a blank line to linux-rk35xx-vendor.config, and after that, all my configurations took effect. Please fix this issue.

How to reproduce?

Simply add the function custom_kernel_config__my_customizations() {} to the configuration file of a specific board, and then add a few kernel_config_set_x configurations within the function, such as:
function custom_kernel_config__my_customizations() {
if [[ -f .config ]]; then
display_alert "Applying custom kernel config for recomputer-rk3576" "armbian-kernel" "info"

	# GPIO PCA953X - enable as built-in (needed for I2C GPIO expander)
	kernel_config_set_y CONFIG_GPIO_PCA953X

	# RTC driver PCF8563 - enable as built-in
	kernel_config_set_y CONFIG_RTC_DRV_PCF8563

	# Morse Wireless (FGH100M) configuration
	kernel_config_set_m CONFIG_WLAN_VENDOR_MORSE
	kernel_config_set_y CONFIG_MORSE_SPI
	kernel_config_set_y CONFIG_MORSE_USER_ACCESS
	kernel_config_set_y CONFIG_MORSE_VENDOR_COMMAND
	kernel_config_set_y CONFIG_MORSE_MONITOR
	kernel_config_set_y CONFIG_MAC80211_MESH
	kernel_config_set_val CONFIG_MORSE_DEBUG_MASK "1"

	# Regulator for Raspberry Pi Touchscreen V2 and camera v3
	kernel_config_set_y CONFIG_REGULATOR_RASPBERRYPI_TOUCHSCREEN_V2
	kernel_config_set_y CONFIG_VIDEO_IMX708
	kernel_config_set_y CONFIG_VIDEO_DW9800W
	kernel_config_set_y CONFIG_REGULATOR_AD5398
	# fan
	kernel_config_set_y CONFIG_SENSORS_PWM_FAN
fi

}

Branch

main (main development branch)

On which host OS are you running the build script and observing this problem?

Debian 12 Bookworm

Are you building on Windows WSL2?

  • Yes, my Ubuntu/Debian/OtherOS is running on WSL2

Relevant log URL

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working as it should

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions