Skip to content

Comments

ORAS download folder doesn't need Git safe#7957

Closed
igorpecovnik wants to merge 1 commit intomainfrom
fix_shallow
Closed

ORAS download folder doesn't need Git safe#7957
igorpecovnik wants to merge 1 commit intomainfrom
fix_shallow

Conversation

@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Mar 16, 2025

Description

After switching #7910 using git safe per cloned repository, this errors out as "not a git directory". After dropping, compilation proceeded.

@leggewie

How Has This Been Tested?

  • kernel compilation natively

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@igorpecovnik igorpecovnik requested a review from a team as a code owner March 16, 2025 15:43
@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels Mar 16, 2025
@leggewie
Copy link
Contributor

Thank you for the ping. It's already midnight here again. I will happily look at it tomorrow if you don't mind.

I'd say, go ahead and commit. The build is currently broken, can't really break something if it's already not working. If there should be a fallout from this commit we can deal with it tomorrow.

That being said I noticed that you pass the directory to git config as $1 in #7910. But that's been there before. At least according to my interpretation of "man git-config" that is not syntactically correct. But hey, if it works! Maybe you feel like looking into exporting $1 to $GIT_DIR and calling git with that environment variable. Just an idea, I did not test it here.

Good night!

@igorpecovnik
Copy link
Member Author

But hey, if it works!

Sadly not in all cases. For now, I will revert #7910 as it seems to be more complex problem. For which more time is needed that available :) GN!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Framework Framework components Needs review Seeking for review size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants