Skip to content

Conversation

@paolosabatino
Copy link
Contributor

@paolosabatino paolosabatino commented Jan 27, 2026

Description

As suggested by @iav here, this PR fixes a qualifier warning treated as an error when building with clang

How Has This Been Tested?

  • compiled rockchip64 edge kernel

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

Summary by CodeRabbit

  • Chores
    • Minor code refinement to improve type consistency in the ARM device USB-C DisplayPort notification system for better code quality.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 27, 2026

📝 Walkthrough

Walkthrough

This PR modifies a single Linux kernel patch file for Rockchip64 6.19, removing the const qualifier from a local struct device *dev variable in the dp_altmode_update_extcon_hpd_status function with no changes to control flow or error handling.

Changes

Cohort / File(s) Summary
Kernel Patch Modification
patch/kernel/archive/rockchip64-6.19/rk3399-usbc-notify-typec-dp-hpd-state-through-extcon.patch
Removed const qualifier from local variable declaration in dp_altmode_update_extcon_hpd_status function

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A whisker-twitch of revision,
const melts like morning dew,
The device now mutable and free,
One small change makes code more true! 🌿✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'rockchip64: fix clang build error' is directly related to the changeset, which fixes a clang compilation error by removing a const qualifier from a local variable declaration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • ISSUECOMMENT-3807681242: Request failed with status code 404

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Jan 27, 2026
@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Jan 27, 2026
@github-actions
Copy link
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Jan 27, 2026
@igorpecovnik igorpecovnik merged commit a621bdc into armbian:main Jan 27, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants