Skip to content

Conversation

@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Jan 30, 2026

Description

Remove ep-gpios property and max-link-speed, set status to okay for pcie0.

How Has This Been Tested?

  • Patching works

Checklist:

  • My changes generate no new warnings

Summary by CodeRabbit

  • Bug Fixes
    • Improved Helios64 board PCI Express endpoint configuration to enhance system stability, hardware compatibility, and peripheral device communication reliability.
    • Optimized endpoint link speed parameters and GPIO signal handling for better power management and overall system performance.
    • Enhanced device communication protocols to ensure stable connections with attached peripherals and improved user experience.

✏️ Tip: You can customize this high-level summary in your review settings.

Remove ep-gpios property and max-link-speed, set status to okay for pcie0.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 30, 2026

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 26 minutes and 31 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

A device-tree patch for the Helios64 board removes the PCIe endpoint GPIO and the max-link-speed property, and sets the &pcie0 node's status to "okay".

Changes

Cohort / File(s) Summary
Device Tree Patch
patch/kernel/archive/rockchip64-6.18/board-helios64-remove-pcie-ep-gpios.patch
Removed ep-gpios = <&gpio2 RK_PD4 GPIO_ACTIVE_HIGH> and max-link-speed = <2> from the &pcie0 node; added status = "okay" to the same node.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐇 I nibble traces where the signals play,
A GPIO gone, the speed swept away,
One tiny word, now softly spoke:
"okay" — the board begins to wake.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bugfix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added 02 Milestone: First quarter release size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Jan 30, 2026
@igorpecovnik igorpecovnik merged commit e05e27b into main Jan 30, 2026
11 of 12 checks passed
@igorpecovnik igorpecovnik deleted the bugfix branch January 30, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants