Skip to content

add Vulkan support and expand 3D package descriptions#9494

Merged
igorpecovnik merged 1 commit intomainfrom
add-vulkan-tools
Mar 6, 2026
Merged

add Vulkan support and expand 3D package descriptions#9494
igorpecovnik merged 1 commit intomainfrom
add-vulkan-tools

Conversation

@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Mar 6, 2026

Summary

  • Add Vulkan support packages to mesa-vpu extension
  • Expand package definitions with individual inline comments for better documentation

Ref: #9423

Changes

  • vulkan-tools: Vulkan utilities (vulkaninfo) for testing and debugging
  • mesa-vulkan-drivers: Vulkan drivers for Mesa GPUs (Panfrost, Lima, Radeon, Intel)
  • Expanded all package definitions with descriptive inline comments:
    • libglx-mesa0: Mesa OpenGL extension library for X11
    • mesa-utils: Mesa utilities for OpenGL information and testing
    • mesa-utils-extra: Additional Mesa demonstration programs
    • glmark2 variants: OpenGL 2.0/3.0 and ES 2.0 benchmark suite with Wayland/X11 backends

Benefits

  • Enables Vulkan development and testing on supported hardware
  • Improves code documentation and makes package purposes clear for maintainers

Test plan

  • Build desktop image with mesa-vpu extension
  • Verify Vulkan tools are installed (vulkaninfo command available)
  • Test Vulkan driver loading on supported hardware (Panfrost/Radeon)

Summary by CodeRabbit

  • New Features
    • Enhanced graphics package set for desktop installations, now including additional 3D rendering tools, graphics benchmarking utilities, and Vulkan support packages.

- Add vulkan-tools: Vulkan utilities (vulkaninfo) for testing and debugging
- Add mesa-vulkan-drivers: Vulkan drivers for Mesa GPUs (Panfrost, Lima, Radeon, Intel)
- Expand package definitions with individual inline comments describing each package:
  - libglx-mesa0: Mesa OpenGL extension library for X11
  - mesa-utils: Mesa utilities for OpenGL information and testing
  - mesa-utils-extra: Additional Mesa demonstration programs
  - glmark2 variants: OpenGL 2.0/3.0 and ES 2.0 benchmark suite with Wayland/X11 backends
- Improves code documentation and makes package purposes clear for maintainers

Signed-off-by: Igor Pecovnik <igor@armbian.com>
@github-actions github-actions bot added 05 Milestone: Second quarter release size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels Mar 6, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 6, 2026

📝 Walkthrough

Walkthrough

The desktop package set in the post_install_kernel_debs__3d function was expanded from a compact grouping to an explicit, detailed list of 3D graphics and Mesa-related packages, including mesa-utils-extra, glmark2 variants, vulkan-tools, and mesa-vulkan-drivers, with enhanced documentation.

Changes

Cohort / File(s) Summary
Mesa/VPU Desktop Package Expansion
extensions/mesa-vpu.sh
Expanded desktop package installation set from few combined packages to granular list of graphics utilities and drivers with enhanced inline comments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 With graphics tools now laid so bare,
Mesa packages everywhere!
Glmark2, Vulkan, drivers bright—
The rabbit's feast of 3D delight! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main changes: adding Vulkan support (vulkan-tools and mesa-vulkan-drivers) and expanding 3D package descriptions with inline comments.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch add-vulkan-tools

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
extensions/mesa-vpu.sh (1)

50-57: Drop the package aliases that are already covered by the explicit packages.

Line 51 is redundant: on Ubuntu Noble, mesa-utils already provides/replaces/conflicts with mesa-utils-extra, and on Debian trixie mesa-utils-extra is only a virtual package provided by mesa-utils. Likewise, Lines 52 and 55 are aliases for the explicit X11 packages already listed here: glmark2-x11 provides glmark2, and glmark2-es2-x11 provides glmark2-es2. Keeping both names makes the install set noisier without changing what gets installed. (code.launchpad.net)

♻️ Proposed cleanup
 		pkgs+=("libglx-mesa0") # Mesa OpenGL extension library for X11
 		pkgs+=("mesa-utils") # Mesa utilities for OpenGL information and testing
-		pkgs+=("mesa-utils-extra") # Additional Mesa demonstration programs
-		pkgs+=("glmark2") # OpenGL 2.0/3.0 benchmark suite
 		pkgs+=("glmark2-wayland") # Glmark2 Wayland backend for benchmarking
 		pkgs+=("glmark2-es2-wayland") # Glmark2 OpenGL ES 2.0 Wayland backend
-		pkgs+=("glmark2-es2") # Glmark2 OpenGL ES 2.0 benchmark support
 		pkgs+=("glmark2-x11") # Glmark2 X11 backend for benchmarking
 		pkgs+=("glmark2-es2-x11") # Glmark2 OpenGL ES 2.0 X11 backend
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@extensions/mesa-vpu.sh` around lines 50 - 57, Remove redundant package
aliases from the pkgs array: drop "mesa-utils-extra" (it's provided by
"mesa-utils"), drop "glmark2" (provided by "glmark2-x11"), and drop
"glmark2-es2" (provided by "glmark2-es2-x11"); leave "mesa-utils",
"glmark2-x11", "glmark2-wayland", "glmark2-es2-wayland", and "glmark2-es2-x11"
as the explicit installs so the install set is not noisy while preserving the
same installed content.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@extensions/mesa-vpu.sh`:
- Around line 50-57: Remove redundant package aliases from the pkgs array: drop
"mesa-utils-extra" (it's provided by "mesa-utils"), drop "glmark2" (provided by
"glmark2-x11"), and drop "glmark2-es2" (provided by "glmark2-es2-x11"); leave
"mesa-utils", "glmark2-x11", "glmark2-wayland", "glmark2-es2-wayland", and
"glmark2-es2-x11" as the explicit installs so the install set is not noisy while
preserving the same installed content.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ea34cbae-64ae-4826-9539-5c18e45f5a0a

📥 Commits

Reviewing files that changed from the base of the PR and between 82a2a16 and 69e0f64.

📒 Files selected for processing (1)
  • extensions/mesa-vpu.sh

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2026

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Mar 6, 2026
@igorpecovnik igorpecovnik merged commit 1b38e53 into main Mar 6, 2026
14 checks passed
@igorpecovnik igorpecovnik deleted the add-vulkan-tools branch March 6, 2026 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants