add Vulkan support and expand 3D package descriptions#9494
Conversation
- Add vulkan-tools: Vulkan utilities (vulkaninfo) for testing and debugging - Add mesa-vulkan-drivers: Vulkan drivers for Mesa GPUs (Panfrost, Lima, Radeon, Intel) - Expand package definitions with individual inline comments describing each package: - libglx-mesa0: Mesa OpenGL extension library for X11 - mesa-utils: Mesa utilities for OpenGL information and testing - mesa-utils-extra: Additional Mesa demonstration programs - glmark2 variants: OpenGL 2.0/3.0 and ES 2.0 benchmark suite with Wayland/X11 backends - Improves code documentation and makes package purposes clear for maintainers Signed-off-by: Igor Pecovnik <igor@armbian.com>
📝 WalkthroughWalkthroughThe desktop package set in the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
extensions/mesa-vpu.sh (1)
50-57: Drop the package aliases that are already covered by the explicit packages.Line 51 is redundant: on Ubuntu Noble,
mesa-utilsalready provides/replaces/conflicts withmesa-utils-extra, and on Debian trixiemesa-utils-extrais only a virtual package provided bymesa-utils. Likewise, Lines 52 and 55 are aliases for the explicit X11 packages already listed here:glmark2-x11providesglmark2, andglmark2-es2-x11providesglmark2-es2. Keeping both names makes the install set noisier without changing what gets installed. (code.launchpad.net)♻️ Proposed cleanup
pkgs+=("libglx-mesa0") # Mesa OpenGL extension library for X11 pkgs+=("mesa-utils") # Mesa utilities for OpenGL information and testing - pkgs+=("mesa-utils-extra") # Additional Mesa demonstration programs - pkgs+=("glmark2") # OpenGL 2.0/3.0 benchmark suite pkgs+=("glmark2-wayland") # Glmark2 Wayland backend for benchmarking pkgs+=("glmark2-es2-wayland") # Glmark2 OpenGL ES 2.0 Wayland backend - pkgs+=("glmark2-es2") # Glmark2 OpenGL ES 2.0 benchmark support pkgs+=("glmark2-x11") # Glmark2 X11 backend for benchmarking pkgs+=("glmark2-es2-x11") # Glmark2 OpenGL ES 2.0 X11 backend🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@extensions/mesa-vpu.sh` around lines 50 - 57, Remove redundant package aliases from the pkgs array: drop "mesa-utils-extra" (it's provided by "mesa-utils"), drop "glmark2" (provided by "glmark2-x11"), and drop "glmark2-es2" (provided by "glmark2-es2-x11"); leave "mesa-utils", "glmark2-x11", "glmark2-wayland", "glmark2-es2-wayland", and "glmark2-es2-x11" as the explicit installs so the install set is not noisy while preserving the same installed content.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@extensions/mesa-vpu.sh`:
- Around line 50-57: Remove redundant package aliases from the pkgs array: drop
"mesa-utils-extra" (it's provided by "mesa-utils"), drop "glmark2" (provided by
"glmark2-x11"), and drop "glmark2-es2" (provided by "glmark2-es2-x11"); leave
"mesa-utils", "glmark2-x11", "glmark2-wayland", "glmark2-es2-wayland", and
"glmark2-es2-x11" as the explicit installs so the install set is not noisy while
preserving the same installed content.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ea34cbae-64ae-4826-9539-5c18e45f5a0a
📒 Files selected for processing (1)
extensions/mesa-vpu.sh
|
✅ This PR has been reviewed and approved — all set for merge! |
Summary
Ref: #9423
Changes
Benefits
Test plan
vulkaninfocommand available)Summary by CodeRabbit