stmmac: Refactor Phytium ethernet patches into modular components#9585
Merged
igorpecovnik merged 1 commit intomainfrom Mar 25, 2026
Merged
stmmac: Refactor Phytium ethernet patches into modular components#9585igorpecovnik merged 1 commit intomainfrom
igorpecovnik merged 1 commit intomainfrom
Conversation
github-actions
bot
added
size/medium
Contributor
📝 WalkthroughWalkthroughAdds Phytium stmmac build object and driver tweaks, changes PHY/MAC interface assignment logic for ACPI/fwnode paths, converts AXI blen storage to a register-mask form, adjusts exported symbol surface, and makes several functions static to silence warnings. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
bot
added
Needs review
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
patch/kernel/archive/uefi-arm64-6.12/1002-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-replace-has_xxxx-with-core_type.patch (1)
30-32: Consider using C-style comments for kernel code.The inline comments use C++ style (
//). While valid, kernel coding style typically prefers C-style comments (/* */).🔧 Suggested change
-+ plat->core_type = DWMAC_CORE_GMAC; // adapt to "net: stmmac: replace has_xxxx with core_type" ++ plat->core_type = DWMAC_CORE_GMAC; /* adapt to: replace has_xxxx with core_type */🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@patch/kernel/archive/uefi-arm64-6.12/1002-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-replace-has_xxxx-with-core_type.patch` around lines 30 - 32, Replace the C++-style inline comment after the assignment to plat->core_type = DWMAC_CORE_GMAC with a kernel-style C comment; update the comment that documents the adaptation to use /* ... */ instead of // near the plat->core_type = DWMAC_CORE_GMAC line so the assignment and the DWMAC_CORE_GMAC symbol remain unchanged but follow kernel coding style.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@patch/kernel/archive/uefi-arm64-6.12/1001-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-remove-axi_blen-array.patch`:
- Around line 22-24: The local array axi_blen declared as "u32
axi_blen[AXI_BLEN]" must be zero-initialized so it doesn't contain garbage if
fwnode_property_read_u32_array() fails; update the declaration of axi_blen to
initialize it (e.g., "= { 0 }") and keep calling
fwnode_property_read_u32_array(np, "snps,blen", axi_blen, AXI_BLEN) as before,
then pass the (now-initialized) axi_blen to
stmmac_axi_blen_to_mask(&axi->axi_blen_regval, axi_blen, AXI_BLEN).
---
Nitpick comments:
In
`@patch/kernel/archive/uefi-arm64-6.12/1002-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-replace-has_xxxx-with-core_type.patch`:
- Around line 30-32: Replace the C++-style inline comment after the assignment
to plat->core_type = DWMAC_CORE_GMAC with a kernel-style C comment; update the
comment that documents the adaptation to use /* ... */ instead of // near the
plat->core_type = DWMAC_CORE_GMAC line so the assignment and the DWMAC_CORE_GMAC
symbol remain unchanged but follow kernel coding style.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 05420a63-67f5-4eff-9ada-173896ff6d42
📒 Files selected for processing (5)
patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patchpatch/kernel/archive/uefi-arm64-6.12/1001-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-remove-axi_blen-array.patchpatch/kernel/archive/uefi-arm64-6.12/1002-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-replace-has_xxxx-with-core_type.patchpatch/kernel/archive/uefi-arm64-6.12/1003-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-pass-struct-device-to-init-exit-methods.patchpatch/kernel/archive/uefi-arm64-6.12/1004-fix-stmmac-compilation-warnings.patch
Comment on lines
+22
to
+24
| + u32 axi_blen[AXI_BLEN]; // adapt to "net: stmmac: remove axi_blen array" | ||
| + fwnode_property_read_u32_array(np, "snps,blen", axi_blen, AXI_BLEN); | ||
| + stmmac_axi_blen_to_mask(&axi->axi_blen_regval, axi_blen, AXI_BLEN); |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cat patch/kernel/archive/uefi-arm64-6.12/1001-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-remove-axi_blen-array.patchRepository: armbian/build
Length of output: 1310
🏁 Script executed:
# Search for fwnode_property_read_u32_array behavior in kernel docs and code
# Also look for stmmac_axi_blen_to_mask implementation
rg "stmmac_axi_blen_to_mask" --type c -A 5Repository: armbian/build
Length of output: 39
🏁 Script executed:
# Check what happens in other parts of stmmac_platform.c with property reads
rg "fwnode_property_read_u32_array" --type c -B 3 -A 3Repository: armbian/build
Length of output: 39
🏁 Script executed:
# Look for how the original code handled the axi_blen struct member
# before this patch - check git history or similar patterns
rg "axi_blen" --type c -B 2 -A 2 | head -100Repository: armbian/build
Length of output: 39
🏁 Script executed:
# The kernel source may not be in this repo. Let's search the patch directory
# to see if there are related patches or documentation
fd "stmmac" patch/kernel/archive/uefi-arm64-6.12/Repository: armbian/build
Length of output: 637
🏁 Script executed:
# Let's look at the context more carefully - check if there's a git repository
# and what the actual state of stmmac files is
git show HEAD:drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c 2>/dev/null | \
grep -A 10 "stmmac_axi_blen_to_mask\|axi_blen_regval" | head -50Repository: armbian/build
Length of output: 39
🏁 Script executed:
# Search web for stmmac_axi_blen_to_mask function behavior
# First, let's check if we can find kernel source info in the repo
find . -name "*.c" -o -name "*.h" | grep -i stmmac | head -20Repository: armbian/build
Length of output: 39
🏁 Script executed:
# Let's examine the related patch 1000 to understand the original context
cat patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patch | head -200Repository: armbian/build
Length of output: 6862
🏁 Script executed:
# Search for stmmac_axi_blen_to_mask in the patch directory
rg "stmmac_axi_blen_to_mask" patch/Repository: armbian/build
Length of output: 430
🏁 Script executed:
# Look for the full patch 1000 to see stmmac_axi_blen_to_mask definition
grep -A 20 "stmmac_axi_blen_to_mask" patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patchRepository: armbian/build
Length of output: 39
🏁 Script executed:
# Let's get the full stmmac_axi_blen_to_mask implementation from patch 1000
wc -l patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patchRepository: armbian/build
Length of output: 182
🏁 Script executed:
# Get more content from patch 1000, focusing on stmmac_axi_blen_to_mask
grep -B 5 -A 25 "stmmac_axi_blen_to_mask" patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patchRepository: armbian/build
Length of output: 39
🏁 Script executed:
# Let's search in patch 1000 for the function definition of stmmac_axi_blen_to_mask
sed -n '/stmmac_axi_blen_to_mask/,/^}/p' patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patch | head -50Repository: armbian/build
Length of output: 39
🏁 Script executed:
# Search in patch 1000 more carefully for stmmac_axi_blen_to_mask
cat patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patch | grep -n "stmmac_axi_blen_to_mask"Repository: armbian/build
Length of output: 39
🏁 Script executed:
# Get the section around that line
cat patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patch | sed -n '200,350p'Repository: armbian/build
Length of output: 4491
🏁 Script executed:
# Search for where stmmac_axi_blen_to_mask is actually defined - look for "static"
cat patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patch | grep -n "axi_blen_to_mask"Repository: armbian/build
Length of output: 39
🏁 Script executed:
# Search more broadly in patch 1000 for axi_blen related code
grep -n "axi_blen" patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patch | head -20Repository: armbian/build
Length of output: 136
🏁 Script executed:
# Let's get the stmmac_platform.c diff section from patch 1000
cat patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patch | sed -n '/diff --git a\/drivers\/net\/ethernet\/stmicro\/stmmac\/stmmac_platform.c/,/^diff --git/p' | head -150Repository: armbian/build
Length of output: 4537
🏁 Script executed:
# Let's see if stmmac_axi_blen_to_mask is a kernel standard function
# by checking web for kernel stmmac documentation
web_search stmmac_axi_blen_to_mask kernel functionRepository: armbian/build
Length of output: 107
🏁 Script executed:
# Let's search in patch 1000 for stmmac_axi_blen_to_mask function definition
# It might be added in the patch's stmmac_platform.c changes
grep -n "stmmac_axi_blen_to_mask" patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patchRepository: armbian/build
Length of output: 39
🏁 Script executed:
# Search for it in patch 1001 as well
grep -n "stmmac_axi_blen_to_mask" patch/kernel/archive/uefi-arm64-6.12/1001-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-remove-axi_blen-array.patchRepository: armbian/build
Length of output: 129
🏁 Script executed:
# Look for stmmac related patches to understand the context better
grep -r "axi_blen_regval" patch/kernel/archive/uefi-arm64-6.12/ | head -20Repository: armbian/build
Length of output: 243
🏁 Script executed:
# Let's search in the kernel doc or other patches for what stmmac_axi_blen_to_mask is
# Check if it's standard kernel function by searching broader context in patch 1000
cat patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patch | grep -A 200 "stmmac_axi_setup_acpi" | head -80Repository: armbian/build
Length of output: 2434
🏁 Script executed:
# Let's find where stmmac_axi_blen_to_mask is defined - search all patches in the directory
grep -r "stmmac_axi_blen_to_mask" patch/kernel/archive/uefi-arm64-6.12/ --include="*.patch"Repository: armbian/build
Length of output: 243
🏁 Script executed:
# Check if stmmac_axi_blen_to_mask is possibly defined in one of the later patches
for f in patch/kernel/archive/uefi-arm64-6.12/*.patch; do
echo "=== $f ==="
grep -c "stmmac_axi_blen_to_mask" "$f" 2>/dev/null || echo "0"
doneRepository: armbian/build
Length of output: 769
🏁 Script executed:
# Let's look at all the changes in patch 1001 more carefully
cat patch/kernel/archive/uefi-arm64-6.12/1001-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-remove-axi_blen-array.patchRepository: armbian/build
Length of output: 1310
🏁 Script executed:
# Let's check if stmmac_axi_blen_to_mask might be defined in kernel headers or docs
# Search for any definition with similar name patterns
grep -r "axi_blen_to_mask\|axi_blen_regval" patch/ --include="*.patch" | head -30Repository: armbian/build
Length of output: 430
🏁 Script executed:
# Let's understand what kernel version this is targeting
grep -i "subject\|version\|kernel" patch/kernel/archive/uefi-arm64-6.12/1001-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-remove-axi_blen-array.patch | head -10Repository: armbian/build
Length of output: 135
🏁 Script executed:
# Search what axi_blen_regval actually is - check struct definitions
grep -r "axi_blen_regval" patch/kernel/archive/uefi-arm64-6.12/ --include="*.patch" -B 2 -A 2Repository: armbian/build
Length of output: 873
🏁 Script executed:
# Let's check if this is indeed adapting to upstream kernel changes
# by looking at the commit message context
grep -A 20 "Subject:" patch/kernel/archive/uefi-arm64-6.12/1001-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-remove-axi_blen-array.patchRepository: armbian/build
Length of output: 1125
🏁 Script executed:
# Check what the upstream kernel change was - look for any documentation
# or check if there are similar patches in 6.19
cat patch/kernel/archive/uefi-arm64-6.19/1001-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-remove-axi_blen-array.patch 2>/dev/null || echo "Not found in 6.19"Repository: armbian/build
Length of output: 1310
🏁 Script executed:
# Let's check if stmmac_axi_blen_to_mask might be a newer kernel function
# by examining what kernel versions are involved
ls -la patch/kernel/archive/ | grep uefi-arm64Repository: armbian/build
Length of output: 384
🏁 Script executed:
# Let's check if there's any definition or documentation of stmmac_axi_blen_to_mask
# by searching in the full patch 1000 for what might be its implementation
wc -l patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patch
tail -150 patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patchRepository: armbian/build
Length of output: 5366
🏁 Script executed:
# Let's search for any structure definitions that might have axi_blen_regval
grep -r "struct stmmac_axi" patch/kernel/archive/uefi-arm64-6.12/ --include="*.patch" -A 20 | head -60Repository: armbian/build
Length of output: 9074
🏁 Script executed:
# Let's look for AXI_BLEN constant definition
grep -r "AXI_BLEN" patch/kernel/archive/uefi-arm64-6.12/ --include="*.patch"Repository: armbian/build
Length of output: 1014
Local array should be initialized to handle property read failures
The uninitialized u32 axi_blen[AXI_BLEN] array on line 23 receives data from fwnode_property_read_u32_array() whose return value is ignored. If the property read fails, undefined values are passed to stmmac_axi_blen_to_mask(). Initialize the array with = { 0 } to ensure deterministic defaults in hardware configuration:
- u32 axi_blen[AXI_BLEN]; // adapt to "net: stmmac: remove axi_blen array"
+ u32 axi_blen[AXI_BLEN] = { 0 }; // adapt to "net: stmmac: remove axi_blen array"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| + u32 axi_blen[AXI_BLEN]; // adapt to "net: stmmac: remove axi_blen array" | |
| + fwnode_property_read_u32_array(np, "snps,blen", axi_blen, AXI_BLEN); | |
| + stmmac_axi_blen_to_mask(&axi->axi_blen_regval, axi_blen, AXI_BLEN); | |
| u32 axi_blen[AXI_BLEN] = { 0 }; // adapt to "net: stmmac: remove axi_blen array" | |
| fwnode_property_read_u32_array(np, "snps,blen", axi_blen, AXI_BLEN); | |
| stmmac_axi_blen_to_mask(&axi->axi_blen_regval, axi_blen, AXI_BLEN); |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@patch/kernel/archive/uefi-arm64-6.12/1001-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-remove-axi_blen-array.patch`
around lines 22 - 24, The local array axi_blen declared as "u32
axi_blen[AXI_BLEN]" must be zero-initialized so it doesn't contain garbage if
fwnode_property_read_u32_array() fails; update the declaration of axi_blen to
initialize it (e.g., "= { 0 }") and keep calling
fwnode_property_read_u32_array(np, "snps,blen", axi_blen, AXI_BLEN) as before,
then pass the (now-initialized) axi_blen to
stmmac_axi_blen_to_mask(&axi->axi_blen_regval, axi_blen, AXI_BLEN).
igorpecovnik
force-pushed
the
arm64stmmac
branch
from
cdafc16 to
86fdfd5
Compare
Split the monolithic Phytium ethernet driver patch into multiple focused patches for better maintainability: - 1000: Original Phytium onboard ethernet drivers and ACPI glue - 1001: Adapt to stmmac removal of axi_blen array - 1002: Adapt to stmmac replace has_xxxx with core_type - 1003: Adapt to stmmac pass struct device to init/exit methods - 1004: Fix stmmac compilation warnings Signed-off-by: Igor Pecovnik <igor@armbian.com>
igorpecovnik
force-pushed
the
arm64stmmac
branch
from
86fdfd5 to
d5e81f2
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patch`:
- Line 520: The code currently assigns the raw return of fw_get_phy_mode(np)
into plat->phy_interface which can store negative errno values; change it to
call fw_get_phy_mode(np) into a temporary int (e.g., mode), check if mode >= 0
and only then assign plat->phy_interface = mode, otherwise leave
plat->phy_interface at its zero-initialized fallback (and optionally log a
warning); this prevents negative values from being used later by __set_bit(mode,
supported_interfaces) and phylink_create() via priv->plat->phy_interface.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5c2df651-4d37-45dc-8a52-3ad12b7ed2ec
📒 Files selected for processing (5)
patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patchpatch/kernel/archive/uefi-arm64-6.12/1001-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-remove-axi_blen-array.patchpatch/kernel/archive/uefi-arm64-6.12/1002-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-replace-has_xxxx-with-core_type.patchpatch/kernel/archive/uefi-arm64-6.12/1003-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-pass-struct-device-to-init-exit-methods.patchpatch/kernel/archive/uefi-arm64-6.12/1004-fix-stmmac-compilation-warnings.patch
✅ Files skipped from review due to trivial changes (2)
- patch/kernel/archive/uefi-arm64-6.12/1003-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-pass-struct-device-to-init-exit-methods.patch
- patch/kernel/archive/uefi-arm64-6.12/1002-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-replace-has_xxxx-with-core_type.patch
🚧 Files skipped from review as they are similar to previous changes (2)
- patch/kernel/archive/uefi-arm64-6.12/1001-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-remove-axi_blen-array.patch
- patch/kernel/archive/uefi-arm64-6.12/1004-fix-stmmac-compilation-warnings.patch
| + np = dev_fwnode(&(pdev->dev)); | ||
| + | ||
| + plat->mac_interface = fw_get_phy_mode(np); | ||
| + plat->phy_interface = fw_get_phy_mode(np); |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Local patch: helper return paths and assignment =="
rg -n -C2 'fw_get_phy_mode|phy-connection-mode|return -ENODEV|plat->phy_interface = fw_get_phy_mode' \
patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patch
echo
echo "== Upstream v6.12 stmmac_main.c consumers of phy_interface =="
curl -fsSL https://raw.githubusercontent.com/torvalds/linux/v6.12/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | \
rg -n -C2 'int mode = priv->plat->phy_interface|__set_bit\(mode|phylink_create'Repository: armbian/build
Length of output: 1393
Don't store raw fw_get_phy_mode() errors in plat->phy_interface.
Line 520 writes the helper's negative errno values straight into plat->phy_interface when ACPI omits or misstates phy-mode. This is unsafe because stmmac later uses priv->plat->phy_interface as a bit index in __set_bit(mode, supported_interfaces) and as the mode parameter to phylink_create(), so a negative value will cause a kernel panic during probe instead of preserving the zero-initialized fallback.
Suggested fix
- plat->phy_interface = fw_get_phy_mode(np);
+ plat->phy_interface = fw_get_phy_mode(np);
+ if (plat->phy_interface < 0)
+ plat->phy_interface = PHY_INTERFACE_MODE_NA;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| + plat->phy_interface = fw_get_phy_mode(np); | |
| plat->phy_interface = fw_get_phy_mode(np); | |
| if (plat->phy_interface < 0) | |
| plat->phy_interface = PHY_INTERFACE_MODE_NA; |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@patch/kernel/archive/uefi-arm64-6.12/1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patch`
at line 520, The code currently assigns the raw return of fw_get_phy_mode(np)
into plat->phy_interface which can store negative errno values; change it to
call fw_get_phy_mode(np) into a temporary int (e.g., mode), check if mode >= 0
and only then assign plat->phy_interface = mode, otherwise leave
plat->phy_interface at its zero-initialized fallback (and optionally log a
warning); this prevents negative values from being used later by __set_bit(mode,
supported_interfaces) and phylink_create() via priv->plat->phy_interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Split the original
net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patchinto:1000-net-stmicro-stmmac-Phytium-onboard-ethernet-drivers-and-ACPI-glue-for-6.x.patch- Original Phytium onboard ethernet drivers and ACPI glue1001-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-remove-axi_blen-array.patch- Adapt to stmmac removal of axi_blen array1002-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-replace-has_xxxx-with-core_type.patch- Adapt to stmmac replace has_xxxx with core_type1003-net-stmicro-stmmac-Phytium-adapt-to-net-stmmac-pass-struct-device-to-init-exit-methods.patch- Adapt to stmmac pass struct device to init/exit methods1004-fix-stmmac-compilation-warnings.patch- Fix stmmac compilation warningsBenefits
Summary by CodeRabbit
Bug Fixes
Chores