Skip to content

framework artifact-rootfs - remove the last vestige of LEGACY_DEBOOTSTRAP#9599

Merged
tabrisnet merged 1 commit intoarmbian:mainfrom
tabrisnet:tabrisnet_ldb
Mar 27, 2026
Merged

framework artifact-rootfs - remove the last vestige of LEGACY_DEBOOTSTRAP#9599
tabrisnet merged 1 commit intoarmbian:mainfrom
tabrisnet:tabrisnet_ldb

Conversation

@tabrisnet
Copy link
Copy Markdown
Collaborator

@tabrisnet tabrisnet commented Mar 26, 2026

Description

This removes a small piece leftover from #9512
This shouldn't have any interesting effects, but possibly it will break/fix the rootfs caching?

19:48:10 <+DC-IRC> [Discord] <igorpec> tabris: i have a feeling that rootfs caching doesn't work.
19:50:56 <+DC-IRC> [Discord] <igorpec> https://github.com/armbian/os/actions/runs/23569530304/job/68630175655 example. recreating locally will go into rebuild
19:52:22 <+DC-IRC> [Discord] <igorpec> still investigating ...

Documentation summary for feature / change

Please delete this section if entry to main documentation is not needed.

If documentation entry is predicted, please provide key elements for further implementation into main documentation and set label to "Needs Documentation". You are welcome to open a PR to documentation or you can leave following information for technical writer:

  • short description (copy / paste of PR title)
  • summary (description relevant for end users)
  • example of usage (how to see this in function)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Test A
  • Test B

Checklist:

Please delete options that are not relevant.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Chores
    • Removed legacy configuration variable handling from the artifact generation process.

@tabrisnet tabrisnet requested a review from a team as a code owner March 26, 2026 17:14
@tabrisnet tabrisnet requested review from corestaq and tystuyfzand and removed request for a team March 26, 2026 17:14
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 120e9052-fe8c-4045-9588-7b0a8454875d

📥 Commits

Reviewing files that changed from the base of the PR and between c2df392 and 1d71ab6.

📒 Files selected for processing (1)
  • lib/functions/artifacts/artifact-rootfs.sh
💤 Files with no reviewable changes (1)
  • lib/functions/artifacts/artifact-rootfs.sh

📝 Walkthrough

Walkthrough

A single-line removal from the artifact_rootfs_config_dump function that eliminates the defaulting and recording of the LEGACY_DEBOOTSTRAP input variable from the artifact configuration dump.

Changes

Cohort / File(s) Summary
Configuration Variable Removal
lib/functions/artifacts/artifact-rootfs.sh
Removed the artifact_input_variables[LEGACY_DEBOOTSTRAP] assignment that previously defaulted the variable to "no" when unset.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 A legacy fades with just one line,
Debootstrap defaults now left behind,
Simpler configs, cleaner and light,
One hop closer to getting it right!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: removing LEGACY_DEBOOTSTRAP from the artifact-rootfs framework component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added 05 Milestone: Second quarter release size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels Mar 26, 2026
@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Mar 26, 2026
@tabrisnet tabrisnet merged commit 81f107d into armbian:main Mar 27, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants