Skip to content

ch13726a: Added missing MIPI_DSI_MODE_VIDEO#9621

Merged
igorpecovnik merged 1 commit intoarmbian:mainfrom
kay-lambdadelta:main
Mar 31, 2026
Merged

ch13726a: Added missing MIPI_DSI_MODE_VIDEO#9621
igorpecovnik merged 1 commit intoarmbian:mainfrom
kay-lambdadelta:main

Conversation

@kay-lambdadelta
Copy link
Copy Markdown
Contributor

@kay-lambdadelta kay-lambdadelta commented Mar 30, 2026

Description

This fixes missing and standard MIPI_DSI_MODE_VIDEO on the patch adding the panel for the Retroid Pocket 5/mini handheld devices (ch13726a based panel).

Without the flag it results in every other frame being skipped when vsync is enabled in applications, resulting in a poor and often choppy framerate (measured at about 30.4 frames per second on my hardware)

How Has This Been Tested?

This has been tested on real hardware (retroid pocket 5) and the results are not only measurable but visibly better. This has not been tested on a mini but I imagine the issue is similar.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed display driver configuration for CH13726A panel to ensure correct operational mode.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3530d609-cc80-41f1-ae6d-2b268c29f4ac

📥 Commits

Reviewing files that changed from the base of the PR and between 57f51bc and bbd1399.

📒 Files selected for processing (1)
  • patch/kernel/archive/sm8250-6.19/0065-drm-panel-Add-DDIC-CH13726A-panel-Signed-off-by-Tegu.patch

📝 Walkthrough

Walkthrough

Updated MIPI-DSI mode flags in the CH13726A panel driver from MIPI_DSI_MODE_VIDEO_BURST to a composite configuration including MIPI_DSI_MODE_VIDEO, MIPI_DSI_MODE_VIDEO_BURST, and MIPI_DSI_CLOCK_NON_CONTINUOUS. This adjustment alters the DSI mode selection context for the panel.

Changes

Cohort / File(s) Summary
CH13726A Panel DSI Configuration
patch/kernel/archive/sm8250-6.19/0065-drm-panel-Add-DDIC-CH13726A-panel-Signed-off-by-Tegu.patch
Updated dsi->mode_flags to include MIPI_DSI_MODE_VIDEO alongside MIPI_DSI_MODE_VIDEO_BURST and MIPI_DSI_CLOCK_NON_CONTINUOUS for DSI mode operation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A panel with flags set just right,
DSI modes now burning bright,
VIDEO and BURST in harmony dance,
The clock runs free—a rabbit's glance! 🐰
Configuration tweaks that delight!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'ch13726a: Added missing MIPI_DSI_MODE_VIDEO' is directly related to and accurately summarizes the main change in the PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... 05 Milestone: Second quarter release labels Mar 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Mar 31, 2026
@igorpecovnik igorpecovnik merged commit 9d0073e into armbian:main Mar 31, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

3 participants