Skip to content

rockchip64-6.18: rewrite kernel patches against 6.18.21#9629

Merged
EvilOlaf merged 1 commit intoarmbian:mainfrom
EvilOlaf:rockchip64-6.18.21
Apr 3, 2026
Merged

rockchip64-6.18: rewrite kernel patches against 6.18.21#9629
EvilOlaf merged 1 commit intoarmbian:mainfrom
EvilOlaf:rockchip64-6.18.21

Conversation

@EvilOlaf
Copy link
Copy Markdown
Member

@EvilOlaf EvilOlaf commented Apr 3, 2026

as per title
also cleans up the latest addition to this patchset

Summary by CodeRabbit

  • New Features

    • Added ODROID-Vu8S display panel support
    • Added Motorcomm YT6801 Ethernet controller support
    • Added microphone LRCK sharing option for ES8328 audio codec
  • Bug Fixes

    • Fixed PHY driver GMII mode support
    • Fixed MAC address retrieval for Motorcomm Ethernet driver
    • Fixed USB2 PHY timer cleanup on device removal
    • Improved Ethernet PHY reset handling in NanoPi Zero2

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 79f055c4-b332-4080-95b2-80966456562e

📥 Commits

Reviewing files that changed from the base of the PR and between db136dc and 9ba1660.

📒 Files selected for processing (9)
  • patch/kernel/archive/rockchip64-6.18/board-odroidm2-support-for-vu8s-panel.patch
  • patch/kernel/archive/rockchip64-6.18/board-orangepi5pro-net-phy-motorcomm-Support-YT8531S-PHY-in-YT6801-Ethe.patch
  • patch/kernel/archive/rockchip64-6.18/board-orangepi5pro-net-stmmac-Add-generic-suspend-resume-helper-for-PCI.patch
  • patch/kernel/archive/rockchip64-6.18/board-orangepi5pro-net-stmmac-Add-glue-driver-for-Motorcomm-YT6801-ethe.patch
  • patch/kernel/archive/rockchip64-6.18/board-orangepi5pro-net-stmmac-dwmac-motorcomm-Fix-compilation-errors-an.patch
  • patch/kernel/archive/rockchip64-6.18/board-orangepi5pro-net-stmmac-dwmac-motorcomm-fix-eFUSE-MAC-Address-Rea.patch
  • patch/kernel/archive/rockchip64-6.18/general-ASoC-codecs-es8328-allow-sharing-LRCK-for-microphone.patch
  • patch/kernel/archive/rockchip64-6.18/rk3528-13-phy-rockchip-inno-usb2-fix-otg-timer-cleanup.patch
  • patch/kernel/archive/rockchip64-6.18/rk3528-14-arm64-dts-rockchip-nanopi-zero2-fix-ethernet-phy-reset.patch

📝 Walkthrough

Walkthrough

Added ODROID-Vu8S display panel support via device-tree configuration and LCD driver initialization. Implemented a complete Motorcomm YT6801 Ethernet glue driver with PCI suspend/resume helpers, PHY mode support, and eFUSE MAC address reading. Enhanced ES8328 audio codec for microphone LRCK sharing, fixed USB PHY delayed-work cleanup, and corrected Ethernet PHY reset handling in device-tree configuration.

Changes

Cohort / File(s) Summary
ODROID-Vu8S Display Support
rk3588s-odroid-m2.dts, panel-ilitek-ili9881c.c
Added DSI panel node with GPIO/pinctrl definitions for LCD and touchscreen resets, PWM backlight configuration, ODROID-Vu8S initialization sequences, and display mode settings. Modified Ethernet clock configuration from output to input mode.
Motorcomm YT6801 Ethernet Glue Driver
drivers/net/ethernet/stmicro/stmmac/Kconfig, drivers/net/ethernet/stmicro/stmmac/Makefile, drivers/net/ethernet/stmicro/stmmac/dwmac-motorcomm.c, drivers/net/ethernet/stmicro/stmmac/stmmac_libpci.*
Introduced new PCI glue driver with STMMAC_LIBPCI build option and reusable suspend/resume helpers. Implemented Motorcomm YT6801 probe/remove, MSI-X IRQ setup, device reset, and eFUSE MAC address reading with polling and initialization sequencing fixes.
Motorcomm PHY Driver Enhancement
drivers/net/ethernet/stmicro/stmmac/.../yt62xx.c
Extended ytphy_rgmii_clk_delay_config() to support GMII mode with YT8531S PHY ID validation, returning -EOPNOTSUPP for unsupported combinations.
ES8328 Audio Codec Feature
sound/soc/codecs/es8328.c
Added conditional device-property check for "everest,mic-lrck-same" to enable microphone LRCK sharing via regmap_update_bits() on DAC control register.
Rockchip USB PHY Cleanup
drivers/phy/rockchip/phy-rockchip-inno-usb2.c
Introduced device-managed cleanup helpers to synchronously cancel delayed works (otg_sm_work, chg_work, sm_work) on probe unwind and driver removal, preventing resource leaks.
RK3528 NanoPi Zero2 Ethernet Reset Fix
arch/arm64/boot/dts/rockchip/rk3528-nanopi-zero2.dtsi
Relocated Ethernet PHY reset control from MDIO PHY node to GMAC1 controller node, updating reset GPIO and delay properties for proper sequencing.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Suggested reviewers

  • igorpecovnik
  • krachlatte
  • paolosabatino
  • JohnTheCoolingFan
  • joekhoobyar
  • catalinii
  • TheSnowfield
  • rpardini

Poem

🐰 Hop, hop! Displays now dance in vibrant hues bright,
Ethernet flows through Motorcomm's restructured might,
Audio sings clearer, USB schedules freed,
Device trees reordered with precise, thoughtful deed!
Patches unified bring hardware to life anew! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically identifies the main objective: rewriting rockchip64 kernel patches to target Linux 6.18.21.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added 05 Milestone: Second quarter release size/medium PR with more then 50 and less then 250 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Apr 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Apr 3, 2026
@EvilOlaf EvilOlaf merged commit ee43699 into armbian:main Apr 3, 2026
12 checks passed
@EvilOlaf EvilOlaf deleted the rockchip64-6.18.21 branch April 3, 2026 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/medium PR with more then 50 and less then 250 lines

Development

Successfully merging this pull request may close these issues.

2 participants