Conversation
allow stable kernel to be fetch automatically
📝 WalkthroughWalkthroughKernel configuration updated to version 7.1 with corresponding function rename. Device tree patch adds DisplayPort Alt Mode support and USB Role switching for Pinebook Pro. An existing eFUSE MAC address timing fix patch was removed. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
config/sources/mainline-kernel.conf.sh (1)
31-33: Clarify conflicting alert semantics in the Torvalds fallback hook.Line 31 states we are using Linus’ repo, but Line 33 reports a “missing torvalds tag,” which reads as the opposite and can confuse incident/debug logs.
Proposed wording tweak
- display_alert "mainline-kernel: missing torvalds tag on 7.1-rc1" "Using KERNELSOURCE='${KERNELSOURCE}' for KERNELBRANCH='${KERNELBRANCH}'" "info" + display_alert "mainline-kernel: forcing torvalds source for 7.1-rc1 (mirror lag workaround)" "Using KERNELSOURCE='${KERNELSOURCE}' for KERNELBRANCH='${KERNELBRANCH}'" "info"🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@config/sources/mainline-kernel.conf.sh` around lines 31 - 33, The two display_alert calls in the Torvalds fallback hook conflict (one says "Using Linus kernel repo for 7.1-rc1" while the other says "missing torvalds tag"), so update the alert text for consistency: use display_alert and the variables KERNELSOURCE and KERNELBRANCH to clearly state that we are falling back to the Torvalds repo because the expected torvalds tag was missing (e.g., "Falling back to Torvalds repo; using KERNELSOURCE='${KERNELSOURCE}' for KERNELBRANCH='${KERNELBRANCH}'" or change the first message to mention the fallback), and ensure both alerts consistently reflect the fallback reason and resulting KERNELSOURCE/KERNELBRANCH values.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@config/sources/mainline-kernel.conf.sh`:
- Around line 31-33: The two display_alert calls in the Torvalds fallback hook
conflict (one says "Using Linus kernel repo for 7.1-rc1" while the other says
"missing torvalds tag"), so update the alert text for consistency: use
display_alert and the variables KERNELSOURCE and KERNELBRANCH to clearly state
that we are falling back to the Torvalds repo because the expected torvalds tag
was missing (e.g., "Falling back to Torvalds repo; using
KERNELSOURCE='${KERNELSOURCE}' for KERNELBRANCH='${KERNELBRANCH}'" or change the
first message to mention the fallback), and ensure both alerts consistently
reflect the fallback reason and resulting KERNELSOURCE/KERNELBRANCH values.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 07566a8d-009e-4d7e-8832-213f2571c8b6
📒 Files selected for processing (3)
config/sources/mainline-kernel.conf.shpatch/kernel/archive/rockchip64-7.0/board-pbp-add-dp-alt-mode.patchpatch/kernel/archive/rockchip64-7.0/net-stmmac-dwmac-motorcomm-fix-eFUSE-MAC-Address-Rea.patch
💤 Files with no reviewable changes (1)
- patch/kernel/archive/rockchip64-7.0/net-stmmac-dwmac-motorcomm-fix-eFUSE-MAC-Address-Rea.patch
|
✅ This PR has been reviewed and approved — all set for merge! |
Description
rollover mainline config to 7.1-rc1 to allow stable builds to be built
remove upstreamed patch from rockchip64
rewrite rockchip64
How Has This Been Tested?
Checklist:
Summary by CodeRabbit
New Features
Updates
Reverts