Skip to content

xt-q8l-v10: forward-port u-boot board patches to v2026.04#9666

Merged
igorpecovnik merged 1 commit intomainfrom
xt-q8l-v10-uboot-v2026.04
Apr 14, 2026
Merged

xt-q8l-v10: forward-port u-boot board patches to v2026.04#9666
igorpecovnik merged 1 commit intomainfrom
xt-q8l-v10-uboot-v2026.04

Conversation

@igorpecovnik
Copy link
Copy Markdown
Member

@igorpecovnik igorpecovnik commented Apr 14, 2026

Summary

Missing from #9663

Forward-ports the xt-q8l-v10 board's u-boot patches into patch/u-boot/v2026.04/. Same three patches that exist in v2025.10:

  • xt-q8l-v10-defconfig.patch
  • xt-q8l-v10-device-tree.patch
  • xt-q8l-v10-device-tree-makefile.patch

v2026.01 skipped the board, so this brings it back for v2026.04 to keep boards using this u-boot version buildable.

Original patches by Paolo Sabatino.

Test plan

  • Build xt-q8l-v10 image with BOOTBRANCH=tag:v2026.04 and confirm the patches apply cleanly
  • Resulting u-boot binary boots on an xt-q8l-v10 device

Summary by CodeRabbit

  • New Features
    • Added bootloader support for the XT-Q8L-V10 RK3288 hardware board variant.
    • Configured core platform parameters including memory management, storage subsystems, and boot sequence.
    • Enabled peripheral support for Ethernet, USB, HDMI, I2C, GPIO, and power management.
    • Defined device tree configurations for optimal hardware initialization and operation.

Same three patches (defconfig, device-tree, device-tree-makefile)
that existed in v2025.10 and earlier. v2026.01 skipped the board;
this brings it back for v2026.04 so boards using this u-boot
version keep building.

Original patches by Paolo Sabatino.
@github-actions github-actions bot added 05 Milestone: Second quarter release size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Apr 14, 2026
@igorpecovnik igorpecovnik merged commit 47f3a5f into main Apr 14, 2026
11 of 12 checks passed
@igorpecovnik igorpecovnik deleted the xt-q8l-v10-uboot-v2026.04 branch April 14, 2026 06:15
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 14, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 09710754-2023-413c-a29c-3b33ca097c5d

📥 Commits

Reviewing files that changed from the base of the PR and between c177b30 and bb3cd24.

📒 Files selected for processing (3)
  • patch/u-boot/v2026.04/board_xt-q8l-v10/xt-q8l-v10-defconfig.patch
  • patch/u-boot/v2026.04/board_xt-q8l-v10/xt-q8l-v10-device-tree-makefile.patch
  • patch/u-boot/v2026.04/board_xt-q8l-v10/xt-q8l-v10-device-tree.patch

Disabled knowledge base sources:

  • Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.


📝 Walkthrough

Walkthrough

Adds U-Boot support for the XT-Q8L-V10 RK3288: new defconfig and public header, board Kconfig/Makefile/MAINTAINERS and SPL board init asserting a power-hold GPIO, DTB/DTS/DTSI entries with extensive board wiring/pinctrl/regulator settings, and DTB build registration.

Changes

Cohort / File(s) Summary
Defconfig
configs/xt-q8l-v10-rk3288_defconfig
Adds board defconfig enabling ARM/SPL/TPL settings, platform params, console/preboot behavior, MMC env, drivers, commands, filesystems, video, network and crypto selections.
Public header
include/configs/xt-q8l-v10_rk3288.h
Introduces board public config header: ROCKCHIP_DEVICE_SETTINGS, BOOT_TARGETS override and maintainer metadata.
Board Kconfig & build
arch/arm/mach-rockchip/rk3288/Kconfig, board/rockchip/xt-q8l-v10_rk3288/Kconfig, board/rockchip/xt-q8l-v10_rk3288/Makefile, board/rockchip/xt-q8l-v10_rk3288/MAINTAINERS
Adds TARGET_XT_Q8L_V10_RK3288 Kconfig, board Kconfig, Makefile entry and MAINTAINERS.
Board source (SPL init)
board/rockchip/xt-q8l-v10_rk3288/xt-q8l-v10-rk3288.c
Adds spl_board_init() requesting GPIO#11 ("power-hold") and driving it high.
Device trees (U-Boot & Linux)
arch/arm/dts/rk3288-xt-q8l-v10-u-boot.dtsi, arch/arm/dts/rk3288-xt-q8l-v10.dts
Adds U-Boot DTSI and board DTS: model/compatible, /chosen (stdout & SPL boot order), memory, CPU OPPs, regulators/PMIC, I2C, GMAC/HDMI/GPU/USB/eMMC/SDMMC wiring, pinctrl groups with boot-phase preservation and DMC/PHY/SDRAM timing.
DTB build registration
arch/arm/dts/Makefile
Registers rk3288-xt-q8l-v10.dtb for RK3288 builds.

Sequence Diagram(s)

sequenceDiagram
  participant ROM as Boot ROM
  participant SPL as SPL
  participant PMIC as I2C PMIC (ACT8846)
  participant GPIO as Power-Hold GPIO#11
  participant MMC as SD/eMMC
  participant UBOOT as U-Boot

  ROM->>SPL: jump to SPL
  SPL->>PMIC: init I2C and configure regulators
  SPL->>GPIO: request GPIO#11 and set output high
  SPL->>MMC: probe SD/eMMC for boot image
  MMC-->>SPL: provide boot image
  SPL->>UBOOT: load and hand off U-Boot with DTB
  UBOOT->>GPIO: keep power-hold asserted while running
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Suggested reviewers

  • igorpecovnik
  • paolosabatino
  • joekhoobyar
  • brentr
  • Tonymac32
  • SuperKali
  • JohnTheCoolingFan
  • prahal
  • krachlatte
  • lanefu

Poem

🐰 I nudged a board into the wood,
A GPIO holds power good,
DTBs, PMICs, pinctrl in play,
SPL wakes early to find the way,
Hoppy boots on patchy day.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch xt-q8l-v10-uboot-v2026.04

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@paolosabatino
Copy link
Copy Markdown
Contributor

Thanks, I forgot that one behind!

Will look forward to use defconfig and dt_uboot directories for this one as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Needs review Seeking for review Patches Patches related to kernel, U-Boot, ... size/large PR with 250 lines or more

Development

Successfully merging this pull request may close these issues.

2 participants