base-files: symlink upstream distro logos to Armbian's

[igorpecovnik]

Summary

Ubuntu hardcodes lookups for ubuntu-logo.svg, ubuntu-logo-text.png, ubuntu-logo-text-dark.png, and newer SVG text variants by filename in GNOME Settings → About and other panels. The LOGO=armbian-logo field in /etc/os-release only helps apps that use the freedesktop icon-spec lookup; the rest reference the filenames directly.

Since we repack base-files as our own, replace the upstream files with relative symlinks:

/usr/share/pixmaps/ubuntu-logo.svg           → armbian-logo.svg
/usr/share/pixmaps/ubuntu-logo-text.png      → armbian-logo-text.png
/usr/share/pixmaps/ubuntu-logo-text-dark.png → armbian-logo-text-dark.png
/usr/share/pixmaps/ubuntu-logo-text.svg      → armbian-logo-text.svg
/usr/share/pixmaps/ubuntu-logo-text-dark.svg → armbian-logo-text-dark.svg

The Armbian logo files are shipped by armbian-bsp-cli (PR #9674) at the same /usr/share/pixmaps/ path.

Test plan

• Tested on real image — Armbian logo shows correctly
• ls -la /usr/share/pixmaps/ubuntu-logo* — all are symlinks to armbian-logo*
• GNOME Settings → About shows Armbian logo

Summary by CodeRabbit

• Chores
  • Updated system branding: where Armbian logo variants exist, existing upstream distro logo assets in the system pixmaps are replaced with symlinks to the Armbian equivalents. Changes are applied conditionally to preserve any upstream files that are not present, ensuring consistent visual branding without removing absent variants.

[coderabbitai]

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one) (1)

• Needs review

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f6e457e4-35e0-45df-b32d-abe67932803c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

📝 Walkthrough

Walkthrough

The build step compile_armbian-base-files() now conditionally post-processes ${destination}/usr/share/pixmaps, replacing certain upstream ubuntu-logo* files with ln -sf symlinks to corresponding armbian-logo* assets when the pixmaps directory and target files exist; absent upstream variants are skipped.

Changes

Cohort / File(s)	Summary
Logo Replacement in Build Process lib/functions/artifacts/artifact-armbian-base-files.sh	Added conditional post-processing after updating etc/os-release: if ${destination}/usr/share/pixmaps exists, iterate suffixes .svg, -text.png, -text-dark.png, -text.svg, -text-dark.svg; for each existing ubuntu-logo${suffix} file delete it and recreate as ln -sf armbian-logo${suffix}. No symlink created if upstream variant absent.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nibble bytes and stitch a link,
Swap badges quick before you blink;
Ubuntu’s face I gently steer,
To Armbian’s emblem, crisp and clear.
A hop, a patch, the build sings bright.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding symlinks to replace upstream distro logo files with Armbian logos in the base-files package.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch base-files-logo-symlinks

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lib/functions/artifacts/artifact-armbian-base-files.sh`:
- Around line 171-191: This block guarded by [[ -d
"${destination}/usr/share/pixmaps" ]] is dead code and should be removed; if you
must keep it for future-proofing, change the logic in the for-loop that
currently always attempts rm/ln on ubuntu-logo* to first check whether the
specific upstream file exists before touching it (i.e. test -f "${upstream}"
before rm -f/ln -sf), and mirror the debian check pattern for ubuntu-logo so we
only replace files present in the base-files payload (refer to the loop using
suffix, the upstream variable
upstream="${destination}/usr/share/pixmaps/ubuntu-logo${suffix}", and
debian_variant="${destination}/usr/share/pixmaps/debian-logo${suffix}").

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 22abd396-6afc-4def-80bd-fd2e2829637e

📥 Commits

Reviewing files that changed from the base of the PR and between e2b9065 and 15d0247.

📒 Files selected for processing (1)

• lib/functions/artifacts/artifact-armbian-base-files.sh