Skip to content

fixing output to /etc/armbian-image-release#9729

Merged
igorpecovnik merged 2 commits intoarmbian:mainfrom
dittodhole:fix-output-to-armbian-image-release
Apr 27, 2026
Merged

fixing output to /etc/armbian-image-release#9729
igorpecovnik merged 2 commits intoarmbian:mainfrom
dittodhole:fix-output-to-armbian-image-release

Conversation

@dittodhole
Copy link
Copy Markdown
Contributor

@dittodhole dittodhole commented Apr 26, 2026

Description

Previously EXTENSIONS and VENDORPRETTYNAME were not successfully output to /etc/armbian-image-release.

Documentation summary for feature / change

N/A

How Has This Been Tested?

I've tested this change with a local build, resulting in a successful output in the final /etc/armbian-image-release.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Chores
    • Improved the formatting and storage of system release information to ensure proper persistence of extension and vendor metadata.

EXTENSIONS and VENDORPRETTYNAME were not contained in the file
@dittodhole dittodhole requested a review from a team as a code owner April 26, 2026 21:28
@dittodhole dittodhole requested review from igorpecovnik and tystuyfzand and removed request for a team April 26, 2026 21:28
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 26, 2026

📝 Walkthrough

Walkthrough

The change modifies how EXTENSIONS and VENDORPRETTYNAME values are persisted to the armbian-image-release file, replacing unquoted or partially quoted assignments with explicitly single-quoted key/value strings written via echo.

Changes

Cohort / File(s) Summary
File format update
lib/functions/rootfs/distro-agnostic.sh
Modified quoting mechanism for EXTENSIONS and VENDORPRETTYNAME variables written to etc/armbian-image-release, switching to single-quoted echo statements to preserve surrounding quotes in stored values.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A shell script's dance with quotes so fine,
Single marks now guard each vital line,
Armbian's release file dressed just right,
Values wrapped in quotes, sparkling bright! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately reflects the main change: fixing output to /etc/armbian-image-release where EXTENSIONS and VENDORPRETTYNAME are now properly persisted with correct quoting.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added 05 Milestone: Second quarter release size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels Apr 26, 2026
@dittodhole dittodhole changed the title fixing to armbian-image-release fixing output to /etc/armbian-image-release Apr 26, 2026
@igorpecovnik igorpecovnik merged commit 73a3e49 into armbian:main Apr 27, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Framework Framework components Needs review Seeking for review size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants