kernel: add linux-initramfs-tool as dep of linux-image package#9731
kernel: add linux-initramfs-tool as dep of linux-image package#9731igorpecovnik merged 1 commit intoarmbian:mainfrom
Conversation
…her alternatives like dracut
📝 WalkthroughWalkthroughThe change modifies the Debian control metadata for the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@lib/functions/compilation/kernel-debs.sh`:
- Line 268: The control file in kernel-debs.sh declares "Depends:
initramfs-tools | linux-initramfs-tool" but runtime logic in functions
image:initrd.sh (update-initramfs call and chmod at initrd.sh:125) and
distro-agnostic.sh (chmod of /etc/kernel/postinst.d/initramfs-tools at
distro-agnostic.sh:305) assumes initramfs-tools; update either by tightening the
dependency to only initramfs-tools (remove the alternative) or make the initrd
build flow provider-agnostic: detect which provider is installed
(initramfs-tools vs linux-initramfs-tool) and invoke the appropriate
commands/paths (replace hardcoded update-initramfs call and
/etc/kernel/postinst.d/initramfs-tools chmods with conditional logic), updating
functions image/initrd.sh and distro-agnostic.sh accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3622abd3-9fa3-4eab-a97a-94518adcebb7
📒 Files selected for processing (1)
lib/functions/compilation/kernel-debs.sh
|
✅ This PR has been reviewed and approved — all set for merge! |
Debian forky has toggled to dracut as its default initrd, and linux-initramfs-tool is a virtual packaged prodided by all alternatives like initramfs-tools/dracut. So add linux-initramfs-tool to dependency would make system with other initrd like dracut happy.
Summary by CodeRabbit