Skip to content

kernel: add linux-initramfs-tool as dep of linux-image package#9731

Merged
igorpecovnik merged 1 commit intoarmbian:mainfrom
amazingfate:initramfs-alt
Apr 27, 2026
Merged

kernel: add linux-initramfs-tool as dep of linux-image package#9731
igorpecovnik merged 1 commit intoarmbian:mainfrom
amazingfate:initramfs-alt

Conversation

@amazingfate
Copy link
Copy Markdown
Contributor

@amazingfate amazingfate commented Apr 27, 2026

Debian forky has toggled to dracut as its default initrd, and linux-initramfs-tool is a virtual packaged prodided by all alternatives like initramfs-tools/dracut. So add linux-initramfs-tool to dependency would make system with other initrd like dracut happy.

Summary by CodeRabbit

  • Chores
    • Updated package dependencies to accept alternative initramfs support tools, providing users with greater flexibility in system configuration options.

@amazingfate amazingfate requested a review from a team as a code owner April 27, 2026 04:44
@amazingfate amazingfate requested review from corestaq and hzyitc and removed request for a team April 27, 2026 04:44
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 27, 2026

📝 Walkthrough

Walkthrough

The change modifies the Debian control metadata for the linux-image package to declare an alternative dependency provider for initramfs support, accepting either initramfs-tools or linux-initramfs-tool instead of requiring only the former.

Changes

Cohort / File(s) Summary
Kernel Package Dependencies
lib/functions/compilation/kernel-debs.sh
Modified linux-image Debian control metadata to accept alternative initramfs dependency: initramfs-tools | linux-initramfs-tool instead of requiring only initramfs-tools.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • swissiety
  • catalinii

Poem

🐰 A choice blooms bright in dependency's hall,
Where initramfs-tools need not stand alone,
linux-initramfs-tool answers the call,
Two paths now open where once was one stone! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding linux-initramfs-tool as an alternative dependency for the linux-image package, which aligns with the changeset that modifies the package control metadata.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added 05 Milestone: Second quarter release size/small PR with less then 50 lines Needs review Seeking for review Framework Framework components labels Apr 27, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@lib/functions/compilation/kernel-debs.sh`:
- Line 268: The control file in kernel-debs.sh declares "Depends:
initramfs-tools | linux-initramfs-tool" but runtime logic in functions
image:initrd.sh (update-initramfs call and chmod at initrd.sh:125) and
distro-agnostic.sh (chmod of /etc/kernel/postinst.d/initramfs-tools at
distro-agnostic.sh:305) assumes initramfs-tools; update either by tightening the
dependency to only initramfs-tools (remove the alternative) or make the initrd
build flow provider-agnostic: detect which provider is installed
(initramfs-tools vs linux-initramfs-tool) and invoke the appropriate
commands/paths (replace hardcoded update-initramfs call and
/etc/kernel/postinst.d/initramfs-tools chmods with conditional logic), updating
functions image/initrd.sh and distro-agnostic.sh accordingly.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3622abd3-9fa3-4eab-a97a-94518adcebb7

📥 Commits

Reviewing files that changed from the base of the PR and between 35e57cc and 144c7b6.

📒 Files selected for processing (1)
  • lib/functions/compilation/kernel-debs.sh

Comment thread lib/functions/compilation/kernel-debs.sh
Copy link
Copy Markdown
Member

@rpardini rpardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions Bot added the Ready to merge Reviewed, tested and ready for merge label Apr 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot removed the Needs review Seeking for review label Apr 27, 2026
@igorpecovnik igorpecovnik merged commit c4e7a9d into armbian:main Apr 27, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

3 participants