fix: rename imx8m bare hook so binman pkg_resources patch can run

[igorpecovnik]

Symptom

uboot-mba8mpxl-ras314-current nightly fails at BINMAN flash.bin with ModuleNotFoundError: No module named 'pkg_resources'. Run 25262303737.

Cause

config/sources/families/imx8m.conf:32 defines pre_config_uboot_target() (bare). The framework treats a bare hook as the full implementation and silently drops any <hook>__<purpose> companions:

WARNING: Extension conflict [ function pre_config_uboot_target already defined!
                              ignoring functions:
                              pre_config_uboot_target__fix_binman_pkg_resources ]

So #9407's binman-fix extension never patches tools/binman/control.py on i.MX 8M boards. Combined with setuptools >= 82 dropping pkg_resources, the u-boot v2024.04 binman blows up the moment make flash.bin runs.

Fix

Rename to pre_config_uboot_target__imx8m_firmware(). Body unchanged — same NXP firmware fetch + per-board copy. Both hooks now coexist and run; order doesn't matter (firmware blob copy vs. Python source rewrite are independent).

Test plan

• Re-run the failing nightly — Patching binman info line should appear and make flash.bin complete.
• Spot-check one other i.MX 8M board (mba8mpxl, imx8mp-tqma8mpql-mba8mpxl) builds clean.

Summary by CodeRabbit

• Refactor

  • Standardized bootloader hook naming to improve configuration clarity and maintainability.
  • Improved firmware handling during bootloader setup so required HDMI/DP and DDR artifacts are fetched and applied automatically.

• Documentation

  • Added comments explaining hook naming conventions and parallel-hook behavior.

[coderabbitai]

📝 Walkthrough

Walkthrough

The i.MX8M bootloader hook in config/sources/families/imx8m.conf was renamed from pre_config_uboot_target() to pre_config_uboot_target__imx8m_firmware() and annotated with comments describing the <hook>__<purpose> convention; the hook body (firmware download, execution, and artifact copying) is unchanged.

Changes

Hook Naming Convention Update

Layer / File(s)	Summary
Documentation & Convention config/sources/families/imx8m.conf	Add comments documenting the <hook>__<purpose> naming pattern and noting that a non-namespaced pre_config_uboot_target() would suppress other registrations.
Function Rename / Implementation config/sources/families/imx8m.conf	Rename pre_config_uboot_target() → pre_config_uboot_target__imx8m_firmware(); keep existing logic that downloads/runs firmware and copies HDMI/DP and DDR artifacts.
Tests / Manifest (none)	No test or manifest changes in this diff.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nibble names in quiet code,
A gentle hop, a tidy mode.
Hooks now wear their purpose clear,
Firmware finds its path sincere.
A tiny change, well placed and bright.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the primary change: renaming a hook function to resolve a build conflict. It accurately reflects the core fix and explains the purpose.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-imx8m-uboot-binman-hook-conflict

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}