fix: rockchip family_tweaks fails on forky — addgroup → groupadd

[igorpecovnik]

Symptom

forky armhf rockchip build (e.g. tinkerboard-current) fails in family_tweaks:

COMMAND: addgroup --system --quiet --gid 900 gpio
bash: line 1: addgroup: command not found
ERROR: Error 127 occurred in main shell

Log: https://paste.armbian.com/iyasuwenum

Cause

addgroup ships in adduser. Debian forky no longer pulls adduser into a minimal rootfs (it's been deprioritised in favour of passwd's groupadd/useradd, which stay Essential). family_tweaks calls addgroup directly via chroot_sdcard, so it 127s the moment the rootfs lacks adduser.

Fix

Switch the four call sites in config/sources/families/rockchip.conf and config/sources/families/rockchip-rv1106.conf from addgroup --system --quiet to groupadd --system. groupadd is in passwd and is present in every Debian/Ubuntu rootfs.

addgroup vs groupadd — relevant differences

	addgroup --system --quiet --gid N name	groupadd --system --gid N name
Package	adduser (deprecated as essential in forky+)	passwd (Essential, all Linux)
--system / GID	identical behaviour	identical
--quiet	suppresses success/warn output	not needed — silent on success
Group already exists	exit 0	exit 9

The exit-9-on-existing difference is gated by a getent group … || guard. rockchip.conf already had that guard; added the same guard to rockchip-rv1106.conf (its addgroup calls were unguarded), so re-running family_tweaks stays idempotent.

Test plan

• Re-run the failing nightly (tinkerboard-current on forky armhf) — family_tweaks should pass and the build progress past the post-cache rootfs stage.
• Spot-check one rk3588 board (orangepi5, nanopct6) to confirm rockchip.conf path still works on bookworm/trixie/noble where adduser is present.
• Re-run any rv1106 board (luckfox-pico-pro) twice in a row to confirm the new getent guard keeps groupadd from erroring with exit 9 on the second run.

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Improved robustness of system group creation during device image builds for Rockchip platforms, ensuring more reliable build outcomes.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0d94e9cc-cc9d-48c6-bc0b-f226c66b2877

📥 Commits

Reviewing files that changed from the base of the PR and between f13bc6b and 1d11ca6.

📒 Files selected for processing (2)

• config/sources/families/rockchip-rv1106.conf
• config/sources/families/rockchip.conf

---

📝 Walkthrough

Walkthrough

Two Rockchip family configuration files are updated to make system group creation (gpio and i2c) idempotent by either checking group existence before creation or switching from addgroup to groupadd, preventing duplicate group errors.

Changes

System Group Creation Idempotency

Layer / File(s)	Summary
Group Creation Logic config/sources/families/rockchip-rv1106.conf	Build-rootfs group creation (gpio GID 900, i2c GID 901) switched from unconditional addgroup to idempotent getent group || groupadd --system --gid pattern with updated comments.
Group Creation Logic config/sources/families/rockchip.conf	Target-rootfs group creation for the same groups changed from addgroup --system --quiet --gid to groupadd --system --gid with updated inline comments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

• Rockchip family tweaks: add to group only if group doesn't exists yet #8479: Directly related group creation idempotency improvements in Rockchip family configurations for gpio/i2c system groups.

Suggested labels

Patches, BSP, size/small

Suggested reviewers

• vidplace7

---

🐰 When groups were added twice, the build would break,
But now with idempotent checks, we're back on track!
getent guards the way, and groupadd's here to stay,
No duplicate errors shall ruin our day! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main fix: replacing addgroup with groupadd in Rockchip family_tweaks to resolve build failures on forky systems where adduser package is not available.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-rockchip-addgroup-on-forky

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}