feat(boards/helios4): enable watchdog extension by default#9757
Conversation
The Helios4 board ships with the Marvell Armada 388 hardware watchdog (orion_wdt) but no userspace kicker is configured in the default image. After a kernel oops the machine stays hung instead of being reset. Enable the existing 'watchdog' extension (already used by helios64, odroidm1, odroidn2): adds the 'watchdog' Debian package to the rootfs and uncomments watchdog-device in /etc/watchdog.conf, so the watchdog daemon (or wd_keepalive fallback) opens /dev/watchdog and keeps the hardware timer alive. A wedged kernel will then trigger a hardware reset within ~60s instead of requiring a manual power-cycle. Tested on Helios4 with kernel 6.18.26-edge-mvebu: kill -9 of the watchdog daemon plus 'echo c > /proc/sysrq-trigger' produced the expected automatic reboot. Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Igor Velkov <325961+iav@users.noreply.github.com>
📝 WalkthroughWalkthroughThe Helios4 board configuration is updated to enable the watchdog extension by adding a single configuration directive. This activates watchdog functionality for the board without modifying other logic, packages, or hooks. ChangesWatchdog Extension Enablement
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
config/boards/helios4.conf (1)
16-16: ⚡ Quick winConsider adding an explanatory comment.
The
uboot-btrfsextension below has a comment explaining its purpose. Adding a brief comment here would help future maintainers understand why watchdog is enabled.📝 Suggested comment
+# Enable hardware watchdog to auto-reboot on kernel hangs enable_extension "watchdog"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@config/boards/helios4.conf` at line 16, Add a short explanatory comment above the enable_extension "watchdog" line that explains why the watchdog extension is enabled (e.g., to ensure automatic recovery/monitoring of stalled boots or to support board-specific hardware reset behavior). Locate the enable_extension "watchdog" entry in the config (look for enable_extension "watchdog") and insert a one-line comment directly above it describing its purpose and any relevant hardware or behavior assumptions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@config/boards/helios4.conf`:
- Line 16: Add a short explanatory comment above the enable_extension "watchdog"
line that explains why the watchdog extension is enabled (e.g., to ensure
automatic recovery/monitoring of stalled boots or to support board-specific
hardware reset behavior). Locate the enable_extension "watchdog" entry in the
config (look for enable_extension "watchdog") and insert a one-line comment
directly above it describing its purpose and any relevant hardware or behavior
assumptions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f7a50025-5468-49e8-af84-5e8ab2cf0fc2
📒 Files selected for processing (1)
config/boards/helios4.conf
|
✅ This PR has been reviewed and approved — all set for merge! |
The Helios4 board ships with the Marvell Armada 388 hardware watchdog (orion_wdt) but no userspace kicker is configured in the default image. After a kernel oops the machine stays hung instead of being reset.
Enable the existing 'watchdog' extension (already used by helios64, odroidm1, odroidn2): adds the 'watchdog' Debian package to the rootfs and uncomments watchdog-device in /etc/watchdog.conf, so the watchdog daemon (or wd_keepalive fallback) opens /dev/watchdog and keeps the hardware timer alive. A wedged kernel will then trigger a hardware reset within ~60s instead of requiring a manual power-cycle.
Tested on Helios4 with kernel 6.18.26-edge-mvebu: kill -9 of the watchdog daemon plus 'echo c > /proc/sysrq-trigger' produced the expected automatic reboot.
Summary by CodeRabbit