Rock-5B-Plus and Rock-5T: Move to u-boot 2026.04#9773
Rock-5B-Plus and Rock-5T: Move to u-boot 2026.04#9773HeyMeco wants to merge 3 commits intoarmbian:mainfrom
Conversation
📝 WalkthroughWalkthroughThis PR updates and extends Armbian's U-Boot support for the Radxa Rock 5 board family, including mainline U-Boot version bumps for Rock 5B Plus to v2026.04, complete addition of Rock 5T board support with device trees and U-Boot configuration, and implementation of runtime memory-type detection for Rock 5B Plus to differentiate LPDDR5 and LPDDR4 variants. ChangesRock 5 Board Family Support
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@config/boards/rock-5t.conf`:
- Around line 35-45: The boot config uses BOOT_SCENARIO="tpl-blob-atf-mainline"
with prepare_boot_configuration (which sets ATF_COMPILE=yes and builds mainline
bl31.elf) but UBOOT_TARGET_MAP still maps BL31 to the proprietary blob via
BL31=${RKBIN_DIR}/${BL31_BLOB}, so the compiled ATF is discarded; fix by either
setting ATF_COMPILE=no immediately after prepare_boot_configuration to skip
mainline ATF, or update UBOOT_TARGET_MAP to use BL31=bl31.elf (matching
rock-5b-plus.conf) so the built bl31.elf is embedded; reference BOOT_SCENARIO,
prepare_boot_configuration, ATF_COMPILE, UBOOT_TARGET_MAP, BL31 and BL31_BLOB
when making the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6ccf2be4-4bd6-4d06-9299-5f096dd7129d
📒 Files selected for processing (8)
config/boards/rock-5b-plus.confconfig/boards/rock-5t.confpatch/u-boot/v2025.04/board_rock-5t/0000-Prior-Upstream-DT-hacks.patchpatch/u-boot/v2025.04/board_rock-5t/0001-Add-Rock5T-dt-modifications.patchpatch/u-boot/v2025.04/board_rock-5t/0002-Add-Rock5T-dts-to-upstream-dir.patchpatch/u-boot/v2025.04/board_rock-5t/0003-Add-Rock5T-support.patchpatch/u-boot/v2025.10/board_rock-5b-plus/0001-Set-NET_PREFER_ROM_MAC_ADDR.patchpatch/u-boot/v2025.10/board_rock-5b-plus/0002-Add-ROCK-5BPlus-support.patch
💤 Files with no reviewable changes (6)
- patch/u-boot/v2025.04/board_rock-5t/0002-Add-Rock5T-dts-to-upstream-dir.patch
- patch/u-boot/v2025.10/board_rock-5b-plus/0001-Set-NET_PREFER_ROM_MAC_ADDR.patch
- patch/u-boot/v2025.10/board_rock-5b-plus/0002-Add-ROCK-5BPlus-support.patch
- patch/u-boot/v2025.04/board_rock-5t/0003-Add-Rock5T-support.patch
- patch/u-boot/v2025.04/board_rock-5t/0000-Prior-Upstream-DT-hacks.patch
- patch/u-boot/v2025.04/board_rock-5t/0001-Add-Rock5T-dt-modifications.patch
|
@coderabbitai review again |
|
Tip For best results, initiate chat on the files or code changes.
[review] |
|
✅ This PR has been reviewed and approved — all set for merge! |
|
Going to retest with the new DDR blob and then merge. All platinum based RK3588 boards should also be retested after the DDR binary change |
Description
For Armbian 2026.05 move Rock-5B-Plus and Rock-5T (both platinum level) to entirely upstream u-boot. This makes patching redundant therefore I removed the old patches too.
How Has This Been Tested?
Armbian_26.2.5_Rock-5b-plus_resolute_vendor_6.1.115_minimal.imgArmbian_26.2.5_Rock-5t_resolute_current_6.18.24_minimal.imgThe SPI was flashed manually with the 2026.04 u-boot and the emmc was flashed with the images mentioned above downloaded from the armbian website.
Checklist:
Summary by CodeRabbit
New Features
Chores