Skip to content

rtl8852bs: re-enable for bleedingedge#9831

Merged
igorpecovnik merged 1 commit into
armbian:mainfrom
EvilOlaf:rtl8852bs
May 16, 2026
Merged

rtl8852bs: re-enable for bleedingedge#9831
igorpecovnik merged 1 commit into
armbian:mainfrom
EvilOlaf:rtl8852bs

Conversation

@EvilOlaf
Copy link
Copy Markdown
Member

@EvilOlaf EvilOlaf commented May 15, 2026

Description

Depends on armbian/wifi-rtl8852bs#5

How Has This Been Tested?

  • build rockchip64 7.1
  • test on hw: nope, no hw on hand

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • New Features

    • Enabled RTL8852BS Wi-Fi driver support for compatible devices
  • Updates

    • RTL8852BS driver updated to a newer version with expanded kernel compatibility (6.1+)

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 15, 2026

📝 Walkthrough

Walkthrough

This PR enables RTL8852BS Wi-Fi driver support for Rockchip64 bleedingedge builds by adding kernel module configuration, removing the branch restriction in the driver build function for kernel versions ≥ 6.1, and updating the pinned upstream source to a May 2026 commit.

Changes

RTL8852BS Driver Support

Layer / File(s) Summary
RTL8852BS driver enablement and source update
config/kernel/linux-rockchip64-bleedingedge.config, lib/functions/compilation/patch/drivers_network.sh
Kernel configuration enables RTL8852BS as a loadable module, driver build function removes bleedingedge branch restriction while maintaining kernel version ≥ 6.1 gating, and upstream source reference is pinned to May 2026 commit.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops through kernel configs bright,
Enabling drivers for Wi-Fi's delight,
Bleedingedge branching now flows just right,
Sources updated, fresh and polite!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'rtl8852bs: re-enable for bleedingedge' directly and specifically describes the main change—re-enabling the RTL8852BS driver for the bleeding-edge branch, which is the primary objective of the PR.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added 05 Milestone: Second quarter release size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Framework Framework components labels May 15, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@lib/functions/compilation/patch/drivers_network.sh`:
- Line 431: The inline comment for the rtl8852bs_ver variable is incorrect;
update the comment next to the assignment of local
rtl8852bs_ver='commit:e1f97d72dfc692e86269e836516162b793395289' to read "#
Commit date: May 14, 2026" so the date matches the actual upstream commit; keep
the variable name rtl8852bs_ver and only change the comment text.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b2c52aaf-a8dc-4713-9e17-7e0a8ddb34fb

📥 Commits

Reviewing files that changed from the base of the PR and between 5e60c01 and d518064.

📒 Files selected for processing (2)
  • config/kernel/linux-rockchip64-bleedingedge.config
  • lib/functions/compilation/patch/drivers_network.sh

Comment thread lib/functions/compilation/patch/drivers_network.sh
Copy link
Copy Markdown
Member

@igorpecovnik igorpecovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if compile, good enough for merge at this point.

@github-actions github-actions Bot added the Ready to merge Reviewed, tested and ready for merge label May 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot removed the Needs review Seeking for review label May 16, 2026
@igorpecovnik igorpecovnik merged commit f89d4d4 into armbian:main May 16, 2026
13 checks passed
@EvilOlaf
Copy link
Copy Markdown
Member Author

You're aware of the depending PR on the actual driver mentioned above?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants