rtl8852bs: re-enable for bleedingedge#9831
Conversation
📝 WalkthroughWalkthroughThis PR enables RTL8852BS Wi-Fi driver support for Rockchip64 bleedingedge builds by adding kernel module configuration, removing the branch restriction in the driver build function for kernel versions ≥ 6.1, and updating the pinned upstream source to a May 2026 commit. ChangesRTL8852BS Driver Support
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lib/functions/compilation/patch/drivers_network.sh`:
- Line 431: The inline comment for the rtl8852bs_ver variable is incorrect;
update the comment next to the assignment of local
rtl8852bs_ver='commit:e1f97d72dfc692e86269e836516162b793395289' to read "#
Commit date: May 14, 2026" so the date matches the actual upstream commit; keep
the variable name rtl8852bs_ver and only change the comment text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: b2c52aaf-a8dc-4713-9e17-7e0a8ddb34fb
📒 Files selected for processing (2)
config/kernel/linux-rockchip64-bleedingedge.configlib/functions/compilation/patch/drivers_network.sh
igorpecovnik
left a comment
There was a problem hiding this comment.
if compile, good enough for merge at this point.
|
✅ This PR has been reviewed and approved — all set for merge! |
|
You're aware of the depending PR on the actual driver mentioned above? |
Description
Depends on armbian/wifi-rtl8852bs#5
How Has This Been Tested?
Checklist:
Summary by CodeRabbit
New Features
Updates