Mekotronics R58X-Pro (vendor): use mainline u-boot for vendor; use new LCD driver

[rpardini]

Mekotronics R58X-Pro (vendor): use mainline u-boot for vendor; use new LCD driver

• 🍃 linux-rk35xx-vendor.config: enable CONFIG_LCD_VK2C21 as module
  • new LCD driver for the Meko-R58X-Pro as a module at drop old lcd_vk2c21 LCD driver that never worked; backport workingvinka,vk2c21 driver; fix Mekos DTs linux-rockchip#482
  • old always-built-in lcd_vk2c21 is gone
• 🌱 mekotronics-r58x-pro: mainline u-boot (and LCD support) also for vendor branch
  • this unifies board config; vendor branch only gets a different DTB name and bluetooth stuff extra on top of edge
  • drop usage of shared vendor/mekotronics config fragments

Summary by CodeRabbit

• New Features

  • Enabled Bluetooth hardware support for compatible boards.
  • Added display driver support for auxiliary display configurations.

• Bug Fixes

  • Improved device configuration handling for legacy vendor branches.
  • Enhanced USB gadget functionality availability across different firmware versions.
  • Refined boot and kernel command-line parameters for better system stability.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request updates board and kernel configuration for the Mekotronics R58X Pro board and broader RK35XX platform. It refactors the vendor/legacy branch setup to apply configuration inline rather than through external sourcing, adds bluetooth and kernel command-line parameters, ensures u-boot device tree patching applies consistently, and enables auxiliary display driver support in the kernel.

Changes

Mekotronics R58X Pro Vendor Configuration

Layer / File(s)	Summary
Vendor/legacy boot parameters and UMS device tree patching config/boards/mekotronics-r58x-pro.csc	The vendor/legacy branch no longer sources the shared vendor config or exits early; instead vendor setup including BOOT_FDT_FILE, BLUETOOTH_HCIATTACH_PARAMS, and SRC_CMDLINE is applied inline. The pre_config_uboot_target__meko_r58x_pro_patch_uboot_dtsi_for_ums function removes its branch guard, so UMS dtsi patching now applies to vendor builds.

RK35XX Kernel Display Configuration

Layer / File(s)	Summary
Auxiliary display and VK2C21 LCD module configuration config/kernel/linux-rk35xx-vendor.config	Kernel configuration enables CONFIG_AUXDISPLAY as a built-in feature and CONFIG_LCD_VK2C21 as a loadable module for VK2C21 LCD display controller support.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A rabbit hops through config land,
With boot flags held in fuzzy hand,
A display blooms where paths once crossed,
No early returns—just gains, no loss!
Device trees patch and modules load,
Building bright along the mekotronics road. 🎉

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the two main changes: switching to mainline u-boot for the vendor branch and enabling the new LCD driver, matching the actual modifications to the board configuration and kernel config files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

✅ This PR has been reviewed and approved — all set for merge!

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@config/kernel/linux-rk35xx-vendor.config`:
- Around line 2331-2332: The CONFIG_LCD_VK2C21 option is not present in the
rk35xx-vendor kernel 6.1 so CONFIG_LCD_VK2C21=m will be ignored; either backport
the VK2C21 driver patches from rockchip64-7.0/7.1 into the rk35xx-vendor-6.1
tree (ensuring you also pull in required Kconfig changes and dependencies like
GPIOLIB and OF), or remove CONFIG_LCD_VK2C21 and CONFIG_AUXDISPLAY from this
config to avoid misleading/unused entries; locate the entries by searching for
CONFIG_LCD_VK2C21 and CONFIG_AUXDISPLAY in the config/kernel file and apply the
chosen change (port patches + add Kconfig and drivers, or delete both config
lines).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 08f6b50f-adc3-48ec-abff-04c2970ca49f

📥 Commits

Reviewing files that changed from the base of the PR and between 5e60c01 and 980d08c.

📒 Files selected for processing (2)

• config/boards/mekotronics-r58x-pro.csc
• config/kernel/linux-rk35xx-vendor.config