build-apps: publish apps images to armbian/distribution - #48
Merged
Conversation
The apps build set release_repository: "distribution" (a label used for the cache path and to gate the upload step) but never set release_target_repository, so it fell back to the default `github.repository` (armbian/ci). The release-upload step (softprops/action-gh-release, repository: RELEASE_TARGET_REPOSITORY) therefore published the appliance images (Home Assistant / OMV / Kali) to armbian/ci releases instead of armbian/distribution, where the old scripts put them. Set release_target_repository: "armbian/distribution", mirroring how build-community.yml overrides it to armbian/community. GH_TOKEN is already secrets.ACCESS_TOKEN (the cross-repo-write PAT used for the community releases), so no secret change is needed provided it has write access to armbian/distribution. Signed-off-by: Igor Pecovnik <igor@armbian.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Disabled knowledge base sources:
WalkthroughThe Build Apps Images workflow now sets Estimated code review effort: 1 (Trivial) | ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
The apps build (run 31269092676) publishes the appliance images (Home Assistant / OMV / Kali) to armbian/ci releases instead of armbian/distribution, where the old scripts put them.
Cause
build-apps.ymlsetrelease_repository: "distribution"— but that value is only a label (used for the storage cache path…/cache/distribution/…and to gate the upload step). The actual GitHub repo the release is uploaded to isrelease_target_repository, andbuild-apps.ymlnever set it. Incomplete-artifact-matrix.yml/build-images-chunk.ymlit then defaults to:and the upload step uses it directly:
build-community.ymlgets this right by overridingrelease_target_repository: "armbian/community"; apps was missing the equivalent line.Fix
GH_TOKENis alreadysecrets.ACCESS_TOKEN(the cross-repo-write PAT that publishes the community releases), so no secret change is needed provided that PAT has write access toarmbian/distribution— worth a quick confirm before the next apps run.