Drop the announce workflows, neither of which has ever run - #1179
Merged
Conversation
pr-announce.yml posts a Discord webhook when a pull request is opened; merge-announce.yml does the same on push. Both are gated on `branches: [ master ]`, while this repository's default branch is `main`. Neither has ever fired. The Actions API reports 0 runs for both, across their entire lifetime — so PR and merge announcements have not been reaching Discord from this repository at all, and removing them changes nothing that currently works. Nothing references either file. If the notifications are actually wanted, the fix is not to keep these but to add one workflow pointed at `main`. Signed-off-by: Igor Pecovnik <igor@armbian.com>
github-actions
Bot
added
size/small
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr-announce.ymlpull_requestonbranches: [ master ],types: [ opened ]merge-announce.ymlpushonbranches: [ master ]The repository's default branch is
main, so neither trigger can match. Run counts come from the Actions API, not inference.The practical consequence is that PR and merge announcements have not been reaching Discord from this repository at all — for as long as these files have existed. Removing them therefore changes nothing that currently works; it just stops two dead files from looking like live integrations.
Nothing else references either file, and no other workflow is gated on
master.If the notifications are actually wanted, the fix isn't to keep these — it's one workflow pointed at
main. Happy to add that instead if you'd prefer.Documentation website preview will be available shortly:
Open WWW preview