Process_CI: point automation docs at armbian/ci (armbian/os deprecated) - #950
Process_CI: point automation docs at armbian/ci (armbian/os deprecated)#950igorpecovnik wants to merge 1 commit into
Conversation
The build pipeline moved from armbian/os (deprecated) to armbian/ci, and repository/download-page automation now lives in armbian.github.io. Update all workflow/badge links accordingly: - standard-support/apps/all/nightly -> armbian/ci build-*.yml workflows - targets-all-not-eos.yaml -> armbian/ci/userpatches/ - repository-update -> armbian.github.io infrastructure-repository-update.yml - webindex refresh -> armbian.github.io data-update-download-index.yml - drop stable.json/nightly.json (versioning now driven by GitHub releases) - remove the Full distro test builds section (no armbian/ci equivalent) - add a deprecation note for armbian/os Signed-off-by: Igor Pecovnik <igor@armbian.com>
github-actions
Bot
added
size/small
WalkthroughUpdated Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/Process_CI.md`:
- Line 147: Update the versioning guidance in Process_CI.md to state that stable
builds may omit versionOverride and will reuse the newest X.Y.Z release by
default. Clarify that versionOverride is only needed to seed a repository or
select a different version, while retaining the existing nightly-build behavior.
- Around line 265-266: Update the documentation links in the nightly image
description to reference targets-release-nightly.yaml under the data branch’s
data/release-targets directory, and link the generator workflow to
generate-build-lists.yaml instead of the unavailable generate-targets.yaml URL.
- Line 259: Update the Build All Artifacts documentation in Process_CI.md to
remove the claim that this job must successfully complete before OS image
generation. State that standard-support and application workflows invoke
artifact-build jobs independently, while Build All Artifacts only pre-populates
the cache and does not gate image workflow execution.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: cb11e9da-87ac-426e-8827-d5f4921f3652
📒 Files selected for processing (1)
docs/Process_CI.md
|
|
||
| - https://github.com/armbian/os/blob/main/stable.json | ||
| - https://github.com/armbian/os/blob/main/nightly.json | ||
| Versioning is driven by the GitHub releases on the target repository — there is no version file to edit. Stable builds require an explicit `versionOverride` (e.g. `26.8.0`); nightly builds pick the newest `<base>-trunk.N` release and bump `N`. |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Do not require versionOverride for every stable build.
Stable workflows default versionOverride to empty. The reusable workflow reuses the newest X.Y.Z release when no override is supplied. An override is required only to seed a repository or select a different version. (raw.githubusercontent.com)
Proposed wording
-Versioning is driven by the GitHub releases on the target repository — there is no version file to edit. Stable builds require an explicit `versionOverride` (e.g. `26.8.0`); nightly builds pick the newest `<base>-trunk.N` release and bump `N`.
+Versioning is driven by the GitHub releases on the target repository — there is no version file to edit. Stable builds reuse the newest `X.Y.Z` release unless `versionOverride` is set; use the override to seed a release or select a different version. Nightly builds pick the newest `<base>-trunk.N` release and bump `N`.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Versioning is driven by the GitHub releases on the target repository — there is no version file to edit. Stable builds require an explicit `versionOverride` (e.g. `26.8.0`); nightly builds pick the newest `<base>-trunk.N` release and bump `N`. | |
| Versioning is driven by the GitHub releases on the target repository — there is no version file to edit. Stable builds reuse the newest `X.Y.Z` release unless `versionOverride` is set; use the override to seed a release or select a different version. Nightly builds pick the newest `<base>-trunk.N` release and bump `N`. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/Process_CI.md` at line 147, Update the versioning guidance in
Process_CI.md to state that stable builds may omit versionOverride and will
reuse the newest X.Y.Z release by default. Clarify that versionOverride is only
needed to seed a repository or select a different version, while retaining the
existing nightly-build behavior.
Source: MCP tools
| Generates all build artifacts cache for targets defined in [targets-all-not-eos.yaml](https://github.com/armbian/os/blob/main/userpatches/targets-all-not-eos.yaml). This build job runs **every 8 hours** and can also be run manually when needed. | ||
| Generates all build artifacts cache for targets defined in [targets-all-not-eos.yaml](https://github.com/armbian/ci/blob/main/userpatches/targets-all-not-eos.yaml). This build job runs on a schedule and can also be run manually when needed. | ||
|
|
||
| This build job **needs to be successfully completed** in order to proceed generating any OS images! |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Do not document Build All Artifacts as a prerequisite.
The standard-support and application workflows run the artifact-build jobs in their own invocation. Build All Artifacts pre-populates the cache; it does not gate image workflow execution. (raw.githubusercontent.com)
Proposed wording
-This build job **needs to be successfully completed** in order to proceed generating any OS images!
+This build job pre-populates the artifact cache used by image builds. Image workflows also build their required artifacts in the same workflow run.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| This build job **needs to be successfully completed** in order to proceed generating any OS images! | |
| This build job pre-populates the artifact cache used by image builds. Image workflows also build their required artifacts in the same workflow run. |
🧰 Tools
🪛 LanguageTool
[style] ~259-~259: Consider a more concise word here.
Context: ... needs to be successfully completed in order to proceed generating any OS images! ## B...
(IN_ORDER_TO_PREMIUM)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/Process_CI.md` at line 259, Update the Build All Artifacts documentation
in Process_CI.md to remove the claim that this job must successfully complete
before OS image generation. State that standard-support and application
workflows invoke artifact-build jobs independently, while Build All Artifacts
only pre-populates the cache and does not gate image workflow execution.
Source: MCP tools
| Generates all nightly (Rolling Release) images defined in [targets-release-nightly.yaml](https://github.com/armbian/armbian.github.io/blob/main/release-targets/targets-release-nightly.yaml). This file is automatically generated from `image-info.json` by the [generate-targets workflow](https://github.com/armbian/armbian.github.io/blob/main/.github/workflows/generate-targets.yaml). | ||
|
|
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Fix the generated-target and generator-workflow references.
The linked generated file is not under main/release-targets; generated output is published under the data branch at data/release-targets. The generator is generate-build-lists.yaml, while the referenced generate-targets.yaml URL is unavailable. ()
Proposed fix
-Generates all nightly (Rolling Release) images defined in [targets-release-nightly.yaml](https://github.com/armbian/armbian.github.io/blob/main/release-targets/targets-release-nightly.yaml). This file is automatically generated from `image-info.json` by the [generate-targets workflow](https://github.com/armbian/armbian.github.io/blob/main/.github/workflows/generate-targets.yaml).
+Generates all nightly (Rolling Release) images defined in [targets-release-nightly.yaml](https://github.com/armbian/armbian.github.io/blob/data/data/release-targets/targets-release-nightly.yaml). This file is automatically generated from `image-info.json` by the [generate-build-lists workflow](https://github.com/armbian/armbian.github.io/blob/main/.github/workflows/generate-build-lists.yaml).📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Generates all nightly (Rolling Release) images defined in [targets-release-nightly.yaml](https://github.com/armbian/armbian.github.io/blob/main/release-targets/targets-release-nightly.yaml). This file is automatically generated from `image-info.json` by the [generate-targets workflow](https://github.com/armbian/armbian.github.io/blob/main/.github/workflows/generate-targets.yaml). | |
| Generates all nightly (Rolling Release) images defined in [targets-release-nightly.yaml](https://github.com/armbian/armbian.github.io/blob/data/data/release-targets/targets-release-nightly.yaml). This file is automatically generated from `image-info.json` by the [generate-build-lists workflow](https://github.com/armbian/armbian.github.io/blob/main/.github/workflows/generate-build-lists.yaml). |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/Process_CI.md` around lines 265 - 266, Update the documentation links in
the nightly image description to reference targets-release-nightly.yaml under
the data branch’s data/release-targets directory, and link the generator
workflow to generate-build-lists.yaml instead of the unavailable
generate-targets.yaml URL.
Source: MCP tools
|
maybe a good idea to archive armbian/os then and update its readme? not necessarily in this order though 😁 |
|
Archive is plan, yes. There is one service left to move out - adding 3rd party packages to repo. Once that is migrated. |
2 participants
The build automation moved out of the now-deprecated
armbian/osrepository:armbian/ci(reusablecomplete-artifact-matrix.yml+ thin track wrappersbuild-standard-support,build-apps,build-all,build-nightly).armbian/armbian.github.io.This updates
Process_CI.mdto match:armbian/cibuild-*.ymltargets-all-not-eos.yaml→armbian/ci/userpatches/armbian.github.ioinfrastructure-repository-update.ymlarmbian.github.iodata-update-download-index.ymlstable.json/nightly.json— versioning is now driven by GitHub releases on the target repo (versionOverridefor stable,-trunk.Nbump for nightly)armbian/ciequivalent)armbian/osThe
armbian/oswiki link for 3rd-party package import is kept (still valid).Documentation website preview will be available shortly:
Open WWW preview