Build-Switches: document SKIP_COMPRESSING - #951
Merged
Conversation
Document the SKIP_COMPRESSING switch (armbian/build#10323) as a sub-option of COMPRESS_OUTPUTIMAGE: a list of file extensions to leave uncompressed (e.g. iso,qcow2), still checksummed when sha is enabled. Signed-off-by: Igor Pecovnik <igor@armbian.com>
github-actions
Bot
added
size/small
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe developer guide now documents the Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/Developer-Guide_Build-Switches.md`:
- Line 490: Move the SKIP_COMPRESSING documentation entry from the obsolete “DO
NOT USE!” section into the active build-switch documentation section above it,
preserving its existing description and placement alongside the other current
switches.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 04c07b8c-6b9c-417c-9d9d-cdd566f78408
📒 Files selected for processing (1)
docs/Developer-Guide_Build-Switches.md
It was added under COMPRESS_OUTPUTIMAGE, which lives below the "DO NOT USE! Obsolete documentation" marker. Move it up into the active Advanced section as a self-contained entry that references COMPRESS_OUTPUTIMAGE. Signed-off-by: Igor Pecovnik <igor@armbian.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the
SKIP_COMPRESSINGbuild switch (from armbian/build#10323) underCOMPRESS_OUTPUTIMAGEinDeveloper-Guide_Build-Switches.md.It is a comma/space-separated list of file extensions to leave uncompressed even when
xz/zstdis enabled (e.g.SKIP_COMPRESSING="iso,qcow2") — for formats consumed as-is (qcow2 imported into a hypervisor, iso mounted as a virtual CD). Still checksummed whenshais set; empty by default.Documentation website preview will be available shortly:
Open WWW preview