Surface armbian-sdk images with Code server logo#138
Open
igorpecovnik wants to merge 1 commit into
Open
Conversation
Adds the SDK ('sdk' application key) to APP_INFO and appLogos so SDK
images surface in the imager UI with the code-server logo and the
label 'Code server + Armbian sources', matching the website's
treatment.
The application key flows through end-to-end already: build action's
manifest writer tags file_application=sdk from the kernel '-sdk'
suffix, and the third-party merge step on armbian.github.io
preserves the field while folding the SDK manifest into the canonical
armbian-images.json that the imager consumes.
🧪 Test BuildsVersion:
ℹ️ About these builds
|
Member
Author
|
Member
|
@igorpecovnik Those images are only SDK? no CLI or Desktop? |
Member
Author
Minimal with some stuff. In theory, they could be desktop variant too. |
Member
Is this mentioned anywhere? Because listing only the SDK as a badge isn't ideal; it would be better to include the CLI as a badge or specify the type of desktop environment, such as GNOME. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mirrors armbian/website#19 on the imager side. SDK images carry
application: "sdk"end-to-end; this PR adds the matchingAPP_INFOandappLogosentries so the imager renders them with the code-server logo and the label Code server + Armbian sources instead of falling back to a generic icon.src/assets/os-logos/code-server.png(same file as on the website).src/assets/os-logos/index.ts—appLogos.sdk→codeServerLogo.src/config/os-info.ts—APP_INFO.sdkwith name, badge color, and logo.How the data reaches imager
file_application: "sdk"(the kernel suffix6.18.26-sdkis detected via the manifest writer'slast_token.isalpha()rule).armbian-images.jsoninto the canonical index verbatim, preserving theapplicationfield.getAppInfo("sdk")andgetImageLogo(_, "sdk")resolve correctly.Related
Test plan
applicationfield.