Skip to content

arm64: dts: rockchip: yy3588: drop non-existent SPI NOR flash#512

Merged
SuperKali merged 1 commit into
armbian:rk-6.1-rkr5.1from
OpenSource-YYT:yy3588-drop-sfc
Jul 8, 2026
Merged

arm64: dts: rockchip: yy3588: drop non-existent SPI NOR flash#512
SuperKali merged 1 commit into
armbian:rk-6.1-rkr5.1from
OpenSource-YYT:yy3588-drop-sfc

Conversation

@SuperKali

Copy link
Copy Markdown
Member

The YY3588 device tree enables the SFC controller with a jedec,spi-nor node, but the board has no SPI NOR fitted. I checked the V3 schematic and there is no flash on the FSPI lines.

Because the SFC is enabled, its fspim1 pins collide with uart7 on gpio2-12. uart7 is wired and enabled, so the pin controller hands the pin to the serial and rejects the SFC, which then floods the log:

rockchip-pinctrl: pin gpio2-12 already requested by feba0000.serial; cannot claim for fe2b0000.spi
rockchip-sfc fe2b0000.spi: Error applying setting, reverse things back

Dropping the sfc override leaves the controller disabled, which is the SoC dtsi default, frees the pins for uart7, and clears the errors.

Tested on a YY3588 with the vendor kernel (6.1.115). armbianmonitor from before the fix: https://paste.armbian.com/dutitimenu

The board enables the SFC controller with a jedec,spi-nor node, but the
YY3588 has no SPI NOR fitted. Its fspim1 pins clash with uart7 on
gpio2-12, and since uart7 is wired and enabled the pin controller rejects
the SFC and floods the log with claim and setup errors. Drop the override
so the SoC dtsi keeps the controller disabled.

Signed-off-by: SuperKali <hello@superkali.me>
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e62217eb-2f67-4f52-8360-72966ab09145

📥 Commits

Reviewing files that changed from the base of the PR and between 6e518f9 and 075da2d.

📒 Files selected for processing (1)
  • arch/arm64/boot/dts/rockchip/rk3588-youyeetoo-yy3588.dts
💤 Files with no reviewable changes (1)
  • arch/arm64/boot/dts/rockchip/rk3588-youyeetoo-yy3588.dts

Walkthrough

This change removes the &sfc SPI Flash Controller node from the rk3588-youyeetoo-yy3588 device tree source file. The removed block included the spi-flash@0 device configured as jedec,spi-nor with bus width properties and a fixed-partitions layout containing a loader@0 partition. No other nodes were modified.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change: removing the YY3588 SPI NOR flash/SFC device tree override.
Description check ✅ Passed The description directly explains the SFC removal, pin conflict, and log errors addressed by the patch.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SuperKali SuperKali merged commit 1cd878b into armbian:rk-6.1-rkr5.1 Jul 8, 2026
2 checks passed
@SuperKali SuperKali deleted the yy3588-drop-sfc branch July 9, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant