arm64: dts: rockchip: yy3588: drop non-existent SPI NOR flash#512
Merged
Merged
Conversation
The board enables the SFC controller with a jedec,spi-nor node, but the YY3588 has no SPI NOR fitted. Its fspim1 pins clash with uart7 on gpio2-12, and since uart7 is wired and enabled the pin controller rejects the SFC and floods the log with claim and setup errors. Drop the override so the SoC dtsi keeps the controller disabled. Signed-off-by: SuperKali <hello@superkali.me>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThis change removes the Estimated code review effort: 1 (Trivial) | ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The YY3588 device tree enables the SFC controller with a jedec,spi-nor node, but the board has no SPI NOR fitted. I checked the V3 schematic and there is no flash on the FSPI lines.
Because the SFC is enabled, its fspim1 pins collide with uart7 on gpio2-12. uart7 is wired and enabled, so the pin controller hands the pin to the serial and rejects the SFC, which then floods the log:
Dropping the sfc override leaves the controller disabled, which is the SoC dtsi default, frees the pins for uart7, and clears the errors.
Tested on a YY3588 with the vendor kernel (6.1.115). armbianmonitor from before the fix: https://paste.armbian.com/dutitimenu