Skip to content

drm/rockchip: dw-dp: ratelimit AUX timeout logging#514

Merged
SuperKali merged 1 commit into
armbian:rk-6.1-rkr5.1from
OpenSource-YYT:dw-dp-aux-timeout-quiet
Jul 8, 2026
Merged

drm/rockchip: dw-dp: ratelimit AUX timeout logging#514
SuperKali merged 1 commit into
armbian:rk-6.1-rkr5.1from
OpenSource-YYT:dw-dp-aux-timeout-quiet

Conversation

@SuperKali

Copy link
Copy Markdown
Member

On a YY3588 the DP0 port is a USB-C DP Alt Mode output. With nothing plugged in, the boot log fills with about 128 lines from the AUX probe:

dw-dp fde50000.dp: AUX timeout, resetting (cmd=0x9 addr=0x0)
dw-dp fde50000.dp: AUX timeout after recovery: cmd=0x9 addr=0x0 size=1, AUX_STATUS=0x0

Every DPCD access times out because there is no sink, and each failed transfer logs one warning for the reset and one info line after recovery. Sixty-four failed transfers at boot means well over a hundred lines for a condition that is completely normal (no cable).

This ratelimits the reset warning and demotes the post-recovery message to debug. Callers already handle the returned -ETIMEDOUT, so nothing else changes.

Tested on a YY3588 (EVB7 V11, vendor kernel 6.1.115): the AUX flood drops from 128 lines to about 20 ratelimited warnings, and DP output on a connected sink is unaffected.

When no DP sink is attached, such as a USB-C DP Alt Mode port with
nothing plugged in, the AUX probe times out on every DPCD access and the
per-transaction "AUX timeout, resetting" warning together with its "after
recovery" note flooded the boot log with over a hundred lines. Ratelimit
the reset warning and demote the post-recovery message to debug, the
callers already handle the returned -ETIMEDOUT.

Signed-off-by: SuperKali <hello@superkali.me>
@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4b3cff20-41e4-4d1a-b248-69e6979f03bd

📥 Commits

Reviewing files that changed from the base of the PR and between 1cd878b and cbc1a61.

📒 Files selected for processing (1)
  • drivers/gpu/drm/rockchip/dw-dp.c

Walkthrough

This change modifies logging behavior in the dw_dp_aux_transfer() function within the Rockchip DisplayPort driver. The initial AUX timeout warning now uses dev_warn_ratelimited() instead of dev_warn(), and the post-recovery AUX timeout message now uses dev_dbg() instead of dev_info(). No functional logic, exported entities, or public interfaces were altered.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: ratelimiting dw-dp AUX timeout logging.
Description check ✅ Passed The description matches the change and explains the logging reduction and unchanged timeout handling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SuperKali SuperKali merged commit 13dcf53 into armbian:rk-6.1-rkr5.1 Jul 8, 2026
2 checks passed
@SuperKali SuperKali deleted the dw-dp-aux-timeout-quiet branch July 8, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant