drm/rockchip: dw-dp: ratelimit AUX timeout logging#514
Conversation
When no DP sink is attached, such as a USB-C DP Alt Mode port with nothing plugged in, the AUX probe times out on every DPCD access and the per-transaction "AUX timeout, resetting" warning together with its "after recovery" note flooded the boot log with over a hundred lines. Ratelimit the reset warning and demote the post-recovery message to debug, the callers already handle the returned -ETIMEDOUT. Signed-off-by: SuperKali <hello@superkali.me>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis change modifies logging behavior in the dw_dp_aux_transfer() function within the Rockchip DisplayPort driver. The initial AUX timeout warning now uses dev_warn_ratelimited() instead of dev_warn(), and the post-recovery AUX timeout message now uses dev_dbg() instead of dev_info(). No functional logic, exported entities, or public interfaces were altered. Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
On a YY3588 the DP0 port is a USB-C DP Alt Mode output. With nothing plugged in, the boot log fills with about 128 lines from the AUX probe:
Every DPCD access times out because there is no sink, and each failed transfer logs one warning for the reset and one info line after recovery. Sixty-four failed transfers at boot means well over a hundred lines for a condition that is completely normal (no cable).
This ratelimits the reset warning and demotes the post-recovery message to debug. Callers already handle the returned -ETIMEDOUT, so nothing else changes.
Tested on a YY3588 (EVB7 V11, vendor kernel 6.1.115): the AUX flood drops from 128 lines to about 20 ratelimited warnings, and DP output on a connected sink is unaffected.