Skip to content

media: rockchip: hdmirx: quiet signal-not-lock polling spam#515

Merged
SuperKali merged 1 commit into
armbian:rk-6.1-rkr5.1from
OpenSource-YYT:yy3588-hdmirx-quiet-spam
Jul 9, 2026
Merged

media: rockchip: hdmirx: quiet signal-not-lock polling spam#515
SuperKali merged 1 commit into
armbian:rk-6.1-rkr5.1from
OpenSource-YYT:yy3588-hdmirx-quiet-spam

Conversation

@SuperKali

Copy link
Copy Markdown
Member

When the HDMI-RX detect reports a source but the receiver never gets a lockable signal, hdmirx_wait_lock_and_get_timing logged two v4l2_err lines on every poll, flooding the log every few seconds.

On the YY3588 the detect reads "present" even with nothing attached, so the poll runs continuously and the log fills with:

rk_hdmirx ...: signal not lock, tmds_clk_ratio:0
rk_hdmirx ...: mu_st:0x0, scdc_st:0x0, dma_st10:0x14

Demote both to v4l2_dbg, matching the pull-out path right above. Verified on a YY3588: with a source the receiver still locks and captures 1080p60, with none the log stays clean.

When a source is reported present but never produces a lockable signal,
hdmirx_wait_lock_and_get_timing logs two v4l2_err lines on every poll,
flooding the kernel log every few seconds. Demote them to v4l2_dbg like
the pull-out path just above, keeping the log clean while the receiver
keeps retrying.

Signed-off-by: SuperKali <hello@superkali.me>
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 08a88526-244a-45f9-b1e5-83929e69aa3b

📥 Commits

Reviewing files that changed from the base of the PR and between bb8f02b and 437126a.

📒 Files selected for processing (1)
  • drivers/media/platform/rockchip/hdmirx/rk_hdmirx.c

Walkthrough

This change modifies the logging behavior in the HDMI RX driver's signal lock timeout handling. Previously, when the signal failed to lock within the timeout period, two error-level log messages (reporting tmds_clk_ratio and a register dump of mu_st/scdc_st/dma_st10) were emitted unconditionally via v4l2_err. These are now emitted as debug-level messages via v4l2_dbg, gated by the debug flag.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: reducing HDMI-RX signal-not-lock log spam.
Description check ✅ Passed The description matches the change and explains the log-spam fix and verification details.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SuperKali SuperKali merged commit 1c4304f into armbian:rk-6.1-rkr5.1 Jul 9, 2026
2 checks passed
@SuperKali SuperKali deleted the yy3588-hdmirx-quiet-spam branch July 9, 2026 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant