ci: lower stall-retry threshold to 30% (inclusive) - #48
Merged
Conversation
The auto-retry-stalled workflow only re-ran a failed build's jobs when more than 50% succeeded; a run with, e.g., 3/10 green (30%) was left red as "systemic". Lower MIN_SUCCESS_PERCENT to 30 and make the guard inclusive (retry when succeeded% >= threshold, i.e. compare with -lt), so a 30% run is retried while genuinely systemic runs (< 30% green) still stay red. Comments and the warning message updated to match (>= instead of >). Signed-off-by: Igor Pecovnik <igor@armbian.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Auto-retry stalled runs workflow only re-ran a failed build's jobs when more than 50% of jobs succeeded, treating anything below as systemic. Run 34019611381 had 3/10 green (30%) and was left red.
Lower the threshold to 30% and make it inclusive so a 30% run gets retried:
MIN_SUCCESS_PERCENT: "50"→"30"-le→-lt(retry whensucceeded% >= threshold, not-retry only when strictly below)>→>=)Verified: 3/10 (30%) → retry, 2/10 (20%) → still systemic (stays red). YAML parses. The manual
ignore_threshold=trueforce path is unchanged.