Skip to content

When the Critic Runs

Arnel Robles edited this page Oct 3, 2026 · 1 revision

The diff decides whether a critic runs

Section 3 of the method. Rules over the diff, not the ticket title, decide whether a critic runs.

Tier from the ticket title is wrong, because the tickets that read as small are the ones that touch auth. needs-review.sh prints every rule a change fires; any output means a critic runs. It ships in this plugin and reads its rules from .lean/needs-review.rules in your repository, so the script is shared and the rules are yours. Start from examples/needs-review.rules.

The patterns are specific to a codebase. The categories transfer: authentication and permissions, anything anonymous, raw SQL, schema and migrations, secrets and logging, concurrency and background work, deletion and retention, build and dependency files, and a test file that removes assertions. Docs, additive fields and assertion-only test additions fire nothing.


Previous: The cascade | Home | Next: Scripts, not instructions

Clone this wiki locally