NA: carve movement monolith by interface (#215, partial) - #296
Merged
Conversation
Split movement.rs (1799 LOC) into focused submodules: - movement/types.rs (~240 LOC): MovementParams, errors, MoveSpec - movement/geometry.rs (~310 LOC): R1-R3 predicates, AOD legality - movement/bank.rs (~230 LOC): bank origin/detection, pair packing - movement/duals.rs (~220 LOC): generate_duals, pack_legs_greedy - movement/emit.rs (~645 LOC): EmitCtx, layer helpers - movement/plan.rs (~260 LOC): plan_aod_movement orchestrator - geometry.rs: shared euclidean_um, ordered_pair predicates Public API stable. All 101 quon_na tests pass. Compaction and zoned splits remain (not blocking — monoliths still work).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #215.
Splits movement.rs (1799 LOC) into 6 focused submodules + extracts shared geometry predicates. Public API stable. All 101 quon_na tests pass.
Compaction.rs and zoned.rs splits remain as follow-up work — the existing monoliths still compile and pass tests unchanged.