wire logical T/Tdag/CCZ into frontend (#311) - #354
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bind logical_t / logical_tdag / logical_ccz as frontend QEC builtins mirroring logical_cx, completing the #283 QEC workload layer that landed in #283/#288 without frontend wiring. - prelude_names / builtins: register the three names + surface-only schemes. - typecheck: let-bound rejection list, dispatch arms, synth_logical_t / synth_logical_tdag (shared surface-only check) and synth_logical_ccz (three surface blocks at equal distance), plus scan_qec_usage. New TypeError variants NonCliffordRequiresSurface / NonCliffordDistanceMismatch with diagnostic codes + Display, encoding the same constraints as quon_qec's WorkloadBuilder validators so lowering never hits a workload-layer rejection. - lower: lowering arms building quantum.dynamic.qec_logical_t / _tdag / _ccz, threading logical ids through the result SSA map. - mlir_bridge qec_dynamic: op names, attrs (a_id/b_id/c_id), verify + builders for the three ops; qec_collect: collection arms calling the workload builders. - examples surface_d3_t.qn / surface_d3_ccz.qn now compile end-to-end through quonc; resource reports carry t_count / ccz_count respectively. - tests: frontend typecheck tests (valid + family/distance rejection) mirroring qec_logical_cx_*, and qec_collect tests for the new ops. - incidental: drop pre-existing dead imports in mlir_bridge pipeline.rs / zx_simplification.rs that blocked the -D warnings clippy gate. No unwrap/expect/anyhow in production src; thiserror+Result throughout.
arniber21
force-pushed
the
311/logical-nonclifford-frontend
branch
from
July 24, 2026 07:21
872a307 to
0e818dc
Compare
arniber21
marked this pull request as ready for review
July 24, 2026 07:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bind logical_t / logical_tdag / logical_ccz as frontend QEC builtins
mirroring logical_cx, completing the #283 QEC workload layer that landed
in #283/#288 without frontend wiring.
synth_logical_tdag (shared surface-only check) and synth_logical_ccz
(three surface blocks at equal distance), plus scan_qec_usage. New
TypeError variants NonCliffordRequiresSurface / NonCliffordDistanceMismatch
with diagnostic codes + Display, encoding the same constraints as
quon_qec's WorkloadBuilder validators so lowering never hits a
workload-layer rejection.
_ccz, threading logical ids through the result SSA map.
builders for the three ops; qec_collect: collection arms calling the
workload builders.
through quonc; resource reports carry t_count / ccz_count respectively.
mirroring qec_logical_cx_*, and qec_collect tests for the new ops.
zx_simplification.rs that blocked the -D warnings clippy gate.
No unwrap/expect/anyhow in production src; thiserror+Result throughout.