Conversation
I haven't updated the script to fetch from RIPE/ARIN in quite a few years, and it's ugly and doesn't work. Instead, use: https://github.com/rezmoss/cloud-provider-ip-addresses Because the list is now a lot longer, using just a slice is too slow: ~40,000ns for the worst case, instead of ~3,800ns. So store as a map of the first byte (or first 2 for IPv6). This makes it consistently ~700ns. Storing it as a map directly bloats the compiles binary by about 15M, so parse it from text on start-up. That's fast enough so should be okay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't updated the script to fetch from RIPE/ARIN in quite a few years, and it's ugly and doesn't work. Instead, use: https://github.com/rezmoss/cloud-provider-ip-addresses
Because the list is now a lot longer, using just a slice is too slow: ~40,000ns for the worst case, instead of ~3,800ns. So store as a map of the first byte (or first 2 for IPv6). This makes it consistently ~700ns.
Storing it as a map directly bloats the compiles binary by about 15M, so parse it from text on start-up. That's fast enough so should be okay.