feat: update TUI scheme toggle shortcut to 's' and add --tui-scheme flag - #30
Conversation
…flag - Removed 'tab' as a shortcut for cycling the TUI control scheme, leaving just 's'. - Added a new CLI flag `--tui-scheme` to `goplayerctl` to set the initial control scheme (arrow, vim, winamp, emacs). - Updated the TUI to display the new 's' shortcut in the help text. - Added bash and zsh auto-completion for `--tui-scheme`. - Documented `--tui-scheme` in `README.md` and `doc/playerctl-go.1.md`. - Added a test in `integration_cli_test.go` to ensure `-h` outputs the new flag.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
| m.refreshPlayers() | ||
| m.updateCurrentPlayerInfo() | ||
| case "tab", "s": | ||
| case "s": |
There was a problem hiding this comment.
Done! Changed to ctrl+s.
There was a problem hiding this comment.
@jules let's try alt+s ctrl+s means something already in termianl land
There was a problem hiding this comment.
Done! Changed to alt+s.
- Replaced "s" with "ctrl+s" to require a modifier, as requested. - Updated the visual text to show "ctrl+s".
- Changed the shortcut from 'ctrl+s' to 'alt+s' based on review feedback. - Updated the TUI text to show 'alt+s'.
1 participant
The user requested to change the 'tab' shortcut to change the TUI control scheme to something less common or configurable via a setting/CLI flag.
This PR implements the following changes:
--tui-schemeflag togoplayerctlthat allows setting the initial scheme (e.g., arrow, vim, winamp, emacs).README.md,doc/playerctl-go.1.md) and adds an integration test to cover the new flag.PR created automatically by Jules for task 2982199604136073761 started by @arran4