Fix: add waveform-is-placeholder class to container on analysis failure - #20
Open
Intenzi wants to merge 2 commits into
Open
Fix: add waveform-is-placeholder class to container on analysis failure#20Intenzi wants to merge 2 commits into
Intenzi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19
Summary
This PR adds a CSS state class
waveform-is-placeholderto the player container when the waveform generation fails and falls back to placeholder peaks (such as on CORS blocked tracks).Details
.waveform-is-placeholderclass at the start ofload()to reset the player state when loading new tracks..waveform-is-placeholderclass inside theload()catch block when analysis fails.test/player.test.jsto verify class toggling on load and failure.Why this is needed
This class allows integrating applications (such as the WordPress Gutenberg editor) to identify when a decorative waveform is being shown and conditionally restyle it (e.g. flat-lining it to look like a standard progress bar instead of displaying randomised audio peaks).
Use of AI Tools
AI assistance: Yes
Tool(s): Antigravity IDE
Model(s): Gemini 3.5 Flash (Low)
Used for: Help in identifying and locating the relevant code lines to fix, approach of fixing. Tests were implemented via it. Final implementation was reviewed and tested by me.