Skip to content

Handling table alias mismatch warning and checking for group duplicat…#335

Merged
rrivera747 merged 17 commits intodevelopfrom
rrivera/handleTableAliasWarnAndCheckFix
Feb 17, 2026
Merged

Handling table alias mismatch warning and checking for group duplicat…#335
rrivera747 merged 17 commits intodevelopfrom
rrivera/handleTableAliasWarnAndCheckFix

Conversation

@rrivera747
Copy link
Contributor

…es, considering table aliases, fixed

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves table-group alias handling by (1) surfacing alias provenance vs active-backbone resolution in the TableGroup XML and (2) strengthening duplicate-group detection to account for alias names and their resolved versions under the active backbone.

Changes:

  • Extend handleGetTableGroupXML() output to include provenance member versions and emit warnings when an alias no longer resolves or resolves to a different version in the active backbone.
  • Update group comparison logic used for duplicate detection so alias matches do not bypass version mismatch checks.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
otsdaq/CoreSupervisors/ConfigurationSupervisorBase.cc Adds provenance/version-alias mismatch reporting to the TableGroup XML response (including warnings and resolved-version context).
otsdaq/ConfigurationInterface/ConfigurationManagerRW.cc Adjusts duplicate-group comparison to consider alias names and still compare resolved versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rrivera747 and others added 4 commits February 17, 2026 09:59
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

Copilot AI commented Feb 17, 2026

@rrivera747 I've opened a new pull request, #336, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 2 commits February 17, 2026 16:13
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Fix typo in ConfigurationSupervisorBase comment
Copy link
Contributor

Copilot AI commented Feb 17, 2026

@rrivera747 I've opened a new pull request, #337, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Copy link
Contributor

Copilot AI commented Feb 17, 2026

@rrivera747 I've opened a new pull request, #338, to work on those changes. Once the pull request is ready, I'll request review from you.

Copilot AI and others added 3 commits February 17, 2026 22:36
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Remove redundant commented code from table alias comparison
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Remove obsolete commented code from ConfigurationManagerRW
@rrivera747 rrivera747 merged commit a16a960 into develop Feb 17, 2026
11 checks passed
@rrivera747 rrivera747 deleted the rrivera/handleTableAliasWarnAndCheckFix branch February 17, 2026 22:53
@github-project-automation github-project-automation bot moved this from 📋 Triage to 🎉 Done in art-daq Work Tracker Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

5 participants