Handling table alias mismatch warning and checking for group duplicat…#335
Handling table alias mismatch warning and checking for group duplicat…#335rrivera747 merged 17 commits intodevelopfrom
Conversation
…es, considering table aliases, fixed
…hub.com/art-daq/otsdaq into rrivera/handleTableAliasWarnAndCheckFix
There was a problem hiding this comment.
Pull request overview
This PR improves table-group alias handling by (1) surfacing alias provenance vs active-backbone resolution in the TableGroup XML and (2) strengthening duplicate-group detection to account for alias names and their resolved versions under the active backbone.
Changes:
- Extend
handleGetTableGroupXML()output to include provenance member versions and emit warnings when an alias no longer resolves or resolves to a different version in the active backbone. - Update group comparison logic used for duplicate detection so alias matches do not bypass version mismatch checks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
otsdaq/CoreSupervisors/ConfigurationSupervisorBase.cc |
Adds provenance/version-alias mismatch reporting to the TableGroup XML response (including warnings and resolved-version context). |
otsdaq/ConfigurationInterface/ConfigurationManagerRW.cc |
Adjusts duplicate-group comparison to consider alias names and still compare resolved versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@rrivera747 I've opened a new pull request, #336, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Fix typo in ConfigurationSupervisorBase comment
|
@rrivera747 I've opened a new pull request, #337, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
|
@rrivera747 I've opened a new pull request, #338, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Remove redundant commented code from table alias comparison
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Remove obsolete commented code from ConfigurationManagerRW
…es, considering table aliases, fixed