Skip to content

Remove redundant commented code from table alias comparison#337

Merged
rrivera747 merged 2 commits intorrivera/handleTableAliasWarnAndCheckFixfrom
copilot/sub-pr-335
Feb 17, 2026
Merged

Remove redundant commented code from table alias comparison#337
rrivera747 merged 2 commits intorrivera/handleTableAliasWarnAndCheckFixfrom
copilot/sub-pr-335

Conversation

Copy link
Contributor

Copilot AI commented Feb 17, 2026

Addresses code review feedback on PR #335 to remove commented-out else continue statement in ConfigurationManagerRW.cc.

The commented lines were redundant - the continue is implicit at the end of the if block when checking table alias mismatches.

Changes:

  • Removed two commented lines from ConfigurationManagerRW.cc:1049-1050
// Before:
if(memberTableAliases.at(memberPair.first) !=
   compareToMemberTableAliases.at(memberPair.first))
{
    isDifferent = true;
    break;
}
// else
//     continue;

// After:
if(memberTableAliases.at(memberPair.first) !=
   compareToMemberTableAliases.at(memberPair.first))
{
    isDifferent = true;
    break;
}

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove commented lines from table alias mismatch PR Remove redundant commented code from table alias comparison Feb 17, 2026
Copilot AI requested a review from rrivera747 February 17, 2026 22:33
@rrivera747 rrivera747 marked this pull request as ready for review February 17, 2026 22:42
@rrivera747 rrivera747 merged commit e620548 into rrivera/handleTableAliasWarnAndCheckFix Feb 17, 2026
@rrivera747 rrivera747 deleted the copilot/sub-pr-335 branch February 17, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants