Skip to content

Release: merge develop into master with LinkedIn org posting, AI provider orchestration, and OpenAI configuration hardening - #101

Merged
artcava merged 24 commits into
masterfrom
develop
May 30, 2026
Merged

Release: merge develop into master with LinkedIn org posting, AI provider orchestration, and OpenAI configuration hardening#101
artcava merged 24 commits into
masterfrom
develop

Conversation

@artcava

@artcava artcava commented May 30, 2026

Copy link
Copy Markdown
Owner

Context

This PR promotes to master the changes already integrated in develop and labeled ready for master, including both issue scope and implementation-level alignments found in the codebase.

Closes #71
Closes #85
Closes #87
Closes #88
Closes #89
Closes #90

What Changed

1. LinkedIn sender: organization page support

  • InSender now resolves author URN with IN_ORG_ID priority (company page) and IN_OWNER fallback (personal profile).
  • Fail-fast handling when both IN_ORG_ID and IN_OWNER are missing.
  • LinkedIn image flow aligned with resolved author URN for both person and organization posting.
  • Configuration and docs updated for IN_ORG_ID.

2. AI service refactor: provider-specific naming

  • AI implementation is now explicitly provider-specific via OpenAiService behind IAiService.
  • Dependency injection registration updated accordingly for clearer provider boundaries.

3. OpenAI parameters externalized via options

  • Introduced OpenAiOptions bound from configuration (OpenAI__*), removing hardcoded endpoints/models/technical parameters from runtime logic.
  • Externalized settings include chat/image endpoints, models, temperatures, token budgets, image size/count, and related knobs.
  • Added startup validation with OpenAiOptionsValidator for safer configuration behavior.

4. Prompt templates moved to configuration

  • Summary and image-prompt templates are now configuration-driven.
  • Runtime placeholder support added ({MaxChars}, {Text}, {Summary}) with validation rules.
  • Prompt tuning now possible without code changes or redeploys.

5. IAiServiceFactory and provider orchestration

  • Added IAiServiceFactory and AiServiceFactory for centralized AI provider resolution.
  • Added provider enum (AiProvider) and generator orchestration integration through scheduled profiles.
  • Architecture now supports future provider extensions with minimal caller impact.

6. Project housekeeping

  • Removed unused System.ServiceModel.Syndication dependency.
  • Documentation technology references aligned with actual dependencies.
  • Infra folder and related Bicep artifacts added to solution structure for improved discoverability.

Testing and Quality

  • Unit tests extended/updated for:
    • AI factory behavior
    • generator/provider orchestration
    • options validation
    • LinkedIn sender org/person/failure branches
    • OpenAI service configuration behavior
  • Regression-sensitive paths around DI, configuration, and provider selection are covered.

Operational Notes

  • Ensure production settings include:
    • IN_ACCESS_TOKEN
    • at least one of IN_OWNER or IN_ORG_ID (IN_ORG_ID takes precedence)
  • Verify OpenAI configuration via OpenAI__* keys, including required prompt placeholders.
  • Timer-trigger execution model and scheduling semantics remain unchanged.

Change Type

  • Feature
  • Refactor
  • Config/Infrastructure
  • Test/Quality
  • Documentation

Checklist

  • Changes aligned with ready-for-master issues
  • Configuration and documentation updated
  • Tests updated for impacted areas
  • No hardcoded secrets introduced

artcava and others added 24 commits April 10, 2026 17:32
@artcava
chore: remove unused System.ServiceModel.Syndication dependency and a…
3c065ae 
…dd infra solution folder

Closes #85
@artcava
docs: remove System.ServiceModel.Syndication from README and fix work…
6a49de1 
…flow reference
@artcava
chore: fix infra solution folder — add all files and modules sub-folder
0b1a2e9
@artcava
chore: add .github/workflows solution folders to sln
da9d6d3
@artcava
chore: remove redundant .github/workflows solution folders (VS shows …
69d60bc 
…them natively via GitHub Actions node)
@artcava
ci: add chore/ prefix to branch naming validation
d157db8
@artcava
Merge pull request #86 from artcava/chore/remove-syndication-add-infr…
063c35c 
…a-solution-folder

chore: remove unused Syndication dependency, fix README and add infra/docs to Solution Items
Marco Cavallo
chore: align XPoster agents and skills for functions workflow
c61d8d9
Marco Cavallo
chore: ignore and untrack C# Dev Kit lscache files
22f57a3
@artcava
Merge pull request #93 from artcava/chore/xposter-agent-skills-alignment
d47a6ed 
chore: align XPoster agents/skills and clean up lscache artifacts
Marco Cavallo
refactor: rename AiService to OpenAiService (#87)
bfd55e4 
- Rename src/Services/AiService.cs to OpenAiService.cs
- Update class name, constructor, and ILogger generic parameter
- Update IAiService DI registration in Program.cs
- Rename tests/Services/AiServiceTests.cs to OpenAiServiceTests.cs
- Update all type references in test file
@artcava
Merge pull request #94 from artcava/feature/87-rename-aiservice-to-op…
2a80f2b 
…enaiservice

refactor: rename AiService to OpenAiService (#87)
Marco Cavallo
feat(insender): add LinkedIn organization page support (#71)
d4dc85b 
- Add ResolveAuthorUrn() helper: returns urn:li:organization:{IN_ORG_ID}
  when IN_ORG_ID is set, falls back to urn:li:person:{IN_OWNER}
- Refactor SendAsync to use ResolveAuthorUrn() instead of reading IN_OWNER directly
- Update generatePayLoad: accept pre-built authorUrn, remove internal URN construction
- Add IN_ORG_ID to local.settings.json.example
- Update docs/configuration.md LinkedIn table (IN_OWNER now optional when IN_ORG_ID set)
- Add 3 tests covering org URN, person URN, and missing-both-vars paths
@artcava
Merge pull request #96 from artcava/feature/71-linkedin-org-page-inse…
64b786e 
…nder

feat(insender): add LinkedIn organization page support (#71)
Marco Cavallo
feat(openai): externalise OpenAI endpoints, models and parameters int…
756e31f 
…o OpenAiOptions (#88)

- Add OpenAiOptions sealed class with defaults for all provider parameters
  (ApiKey, ChatEndpoint, ChatModel, SummaryTemperature, SummaryMaxTokensPerChar,
  SummarySafetyMarginChars, ImageEndpoint, ImageModel, ImageSize, ImageCount)
- Refactor OpenAiService: inject IOptions<OpenAiOptions>, remove all hard-coded literals
  and redundant OPENAI_API_KEY env-var guards in GetSummaryAsync/GetImagePromptAsync
- Register Configure<OpenAiOptions> from 'OpenAI' section in Program.cs
- Replace OPENAI_API_KEY flat var with OpenAI__* double-underscore keys in local.settings.json.example
- Update docs/configuration.md AI section with full OpenAiOptions parameter table
- Update OpenAiServiceTests: BuildService now accepts IOptions<OpenAiOptions>
@artcava
Merge pull request #97 from artcava/feature/88-externalise-openai-opt…
0468da4 
…ions

feat(openai): externalise OpenAI endpoints, models and parameters into OpenAiOptions (#88)
Marco Cavallo
feat(openai): externalise prompt templates into OpenAiOptions (#89)
14b9257
Marco Cavallo
feat(openai): add startup validation for prompt template placeholders (…
7fb4852 
…#89)
@artcava
Merge pull request #98 from artcava/feature/89-externalise-prompt-tem…
249a010 
…plates

feat(openai): externalise prompt templates into OpenAiOptions (#89)
Marco Cavallo
chore: add NuGet.Config to pin restore to nuget.org only
52012bf
@artcava
Merge pull request #99 from artcava/chore/add-nuget-config
e7a9d90 
chore: add NuGet.Config to pin restore to nuget.org only
Marco Cavallo
feat: add AiServiceFactory, ScheduledGenerationProfile and AI provide…
cafc606 
…r orchestration in GeneratorFactory

- Add IAiServiceFactory and AiServiceFactory for provider-based IAiService resolution
- Add AiProvider enum (OpenAi, Perplexity placeholders)
- Add ScheduledGenerationProfile to model hour/sender/generator/provider slots
- Refactor GeneratorFactory to resolve sender and AI service via profiles and IAiServiceFactory
- Update FeedGenerator to accept nullable IAiService with null-safety guards
- Update Program.cs DI registrations for AiServiceFactory and new abstractions
- Add global.json to pin SDK to .NET 8.0.421 and resolve MSB4011 warnings
- Fix CS1998 in IgSender.UploadImageToPublicUrl
- Fix duplicate Content items in XPoster.csproj after SDK alignment
- Add XML docs for all new public types and members
- Add unit tests: AiServiceFactoryTests, missing FeedGenerator null-safety cases,
  GeneratorFactory IAiServiceFactory interaction tests
Marco Cavallo
fix: use (object?)null in Moq Returns to resolve CS8625 under TreatWa…
74ba6da 
…rningsAsErrors
@artcava
Merge pull request #100 from artcava/feature/ai-service-factory-orche…
871542a 
…stration

feat: add multi-AI-provider support via IAiServiceFactory and ScheduledGenerationProfile
@artcava
artcava merged commit edeee86 into master May 30, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment