Skip to content

Fix export bulk csv - #2184

Merged
anvit merged 3 commits into
artefactual:qa/2.xfrom
danloveg:dev/2179-fix-export-bulk-csv
Nov 14, 2025
Merged

Fix export bulk csv#2184
anvit merged 3 commits into
artefactual:qa/2.xfrom
danloveg:dev/2179-fix-export-bulk-csv

Conversation

@danloveg

@danloveg danloveg commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

Closes #2179

  • Make a new CSV writer for each row so that each description gets written to a separate file.
  • Fix duplicate description count ($itemsExported was incremented twice each loop iteration)

Previously, the same CSV writer at the same path was being used every iteration, so it was essentially working like a regular csv:export. These changes make it so that each description gets written to a separate file which I believe is the proper way for this task to function.

@danloveg danloveg changed the title Dev/2179 fix export bulk csv Fix export bulk csv Oct 1, 2025
@sarah-mason sarah-mason added the Community Pull requests that have been contributed from community members outside Artefactual label Oct 2, 2025
@anvit anvit added this to the 2.10.1 milestone Nov 6, 2025

@anvit anvit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks @danloveg !

@anvit
anvit merged commit 0e8e33d into artefactual:qa/2.x Nov 14, 2025
6 checks passed
@danloveg
danloveg deleted the dev/2179-fix-export-bulk-csv branch November 14, 2025 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Pull requests that have been contributed from community members outside Artefactual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem: Bad code on new CSV Bulk import CLI

3 participants