Skip to content

tests(docx-io): throw Error objects in applyDocxTracking.spec to sati…#152

Merged
arthrod merged 1 commit intofeat/docx-import-export-suggestions-commentsfrom
claude/fix-docx-tracking-lint-JbQJu
Feb 24, 2026
Merged

tests(docx-io): throw Error objects in applyDocxTracking.spec to sati…#152
arthrod merged 1 commit intofeat/docx-import-export-suggestions-commentsfrom
claude/fix-docx-tracking-lint-JbQJu

Conversation

@arthrod
Copy link
Owner

@arthrod arthrod commented Feb 24, 2026

…sfy useThrowOnlyError lint rule

https://claude.ai/code/session_01V5zGakMe6vBHVZEAinNrsC

Checklist

  • yarn typecheck
  • yarn lint:fix
  • yarn test
  • yarn brl
  • yarn changeset
  • ui changelog

Summary by Sourcery

Tests:

  • Adjust applyDocxTracking.spec to throw Error objects in mocked rangeRef calls to comply with linting rules.

@codesandbox
Copy link

codesandbox bot commented Feb 24, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@sourcery-ai
Copy link

sourcery-ai bot commented Feb 24, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates docx-io applyDocxTracking tests to throw proper Error objects instead of string literals, aligning with the useThrowOnlyError lint rule while preserving test behavior.

File-Level Changes

Change Details Files
Replace string-throwing test doubles with proper Error instances in applyDocxTracking tests.
  • Update mocked api.rangeRef implementation in a tracking-related test case to throw new Error with the same message instead of a string literal.
  • Update mocked api.rangeRef implementation in a comment-tracking-related test case to throw new Error with the same message instead of a string literal.
  • Preserve existing test structure and expectations while satisfying the useThrowOnlyError lint rule.
packages/docx-io/src/lib/applyDocxTracking.spec.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@vercel
Copy link

vercel bot commented Feb 24, 2026

Deployment failed with the following error:

Resource is limited - try again in 3 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/arthrods-projects?upgradeToPro=build-rate-limit

@railway-app railway-app bot temporarily deployed to Plate Editor / plate-pr-152 February 24, 2026 18:43 Destroyed
@railway-app
Copy link

railway-app bot commented Feb 24, 2026

🚅 Deployed to the plate-pr-152 environment in Plate Editor

Service Status Web Updated (UTC)
www 🕐 Queued (View Logs) Web Feb 24, 2026 at 6:43 pm

@arthrod arthrod merged commit 03d1130 into feat/docx-import-export-suggestions-comments Feb 24, 2026
1 of 4 checks passed
@gemini-code-assist
Copy link

Summary of Changes

Hello @arthrod, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on code quality and consistency by refactoring existing test cases. The primary goal is to align error handling within tests with a specific linting rule, which mandates throwing Error objects rather than plain string literals. This change improves the robustness and maintainability of the test suite by standardizing error propagation.

Highlights

  • Lint Rule Compliance: Updated test cases in applyDocxTracking.spec.ts to throw Error objects instead of string literals, ensuring compliance with the useThrowOnlyError lint rule.
Activity
  • The author has confirmed successful execution of yarn typecheck.
  • The author has confirmed successful execution of yarn lint:fix.
  • The author has confirmed successful execution of yarn test.
  • The author has confirmed successful execution of yarn brl.
  • The author has confirmed successful execution of yarn changeset.
  • The author has confirmed the ui changelog has been addressed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@arthrod arthrod deleted the claude/fix-docx-tracking-lint-JbQJu branch February 24, 2026 18:43
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@coderabbitai
Copy link

coderabbitai bot commented Feb 24, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 221830e and aca7fdb.

📒 Files selected for processing (1)
  • packages/docx-io/src/lib/applyDocxTracking.spec.ts

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Improved error handling consistency in test cases by updating exception handling to use proper Error objects.

Walkthrough

Test cases in the applyDocxTracking specification file now throw Error objects instead of string literals, improving exception consistency and alignment with standard JavaScript error handling practices.

Changes

Cohort / File(s) Summary
Test Error Handling
packages/docx-io/src/lib/applyDocxTracking.spec.ts
Two test cases updated to throw Error objects instead of string literals for proper exception typing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Strings once flew through the testing air,
Now Errors stand with proper care,
Two little throws, both fixed just right,
Type-safe exceptions burning bright!

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/fix-docx-tracking-lint-JbQJu

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates two test mocks in applyDocxTracking.spec.ts to throw Error objects instead of string literals. This change correctly satisfies the useThrowOnlyError linting rule and is a good practice for error handling in TypeScript. By throwing Error objects, stack traces are preserved, which aids in debugging. The changes are correct and improve the test code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants