feat(packaging): enforce the four-binary native payload - #351
Draft
sandersonstabo wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #350.
Enforces the native version payload as exactly four versioned binaries under bin/: ae, installer, editor, and forge (with .exe on Windows). Only resources/ and licenses/ are optional; extra binaries, component directories, and legacy Broker/Node/Electron/host layouts are rejected by both manifest generation and CLI verification.
Coverage includes every required binary, wrong-platform names, extra bin members, optional-tree hashing, unsafe manifest entries, legacy layout rejection, and bounded diagnostics.
Checks: 13-target jobs=1 Bazel build; CLI and installer unit suites plus four packaging suites (6/6 targets); 11 fresh strict Clippy markers; exhaustive root Rust format gate; cargo metadata --locked --offline; deterministic archive SHA-256 and stable guarded hashes; Bazel shutdown 0.
Excludes launch/control behavior, installer retirement, and conversation/Statig source.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Enforces the native payload as exactly four versioned binaries under
bin/(ae,installer,editor,forge, with.exeon Windows); previously the manifest covered any regular file present. Onlyresources/andlicenses/are optional now, and their files must be non-executable. Both manifest generation and CLI verification reject extra binaries, component directories, and legacyBroker/Node/Electron/hostmembers.Scope
Written for commit 39a5604. Summary will update on new commits.