feat(EMI-2662): Autoscroll as user progresses through checkout. #16527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#5733 Bundle Size — 9.53MiB (+0.01%).0e3fcb8(current) vs 9d5b88f main#5729(baseline) Warning Bundle contains 34 duplicate packages – View duplicate packages Bundle metrics
|
| Current #5733 |
Baseline #5729 |
|
|---|---|---|
 Initial JS |
3.7MiB(~+0.01%) |
3.7MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
40.73% |
37.44% |
| Chunks |
102 |
102 |
| Assets |
105 |
105 |
| Modules |
5945(+0.03%) |
5943 |
| Duplicate Modules |
588 |
588 |
| Duplicate Code |
4.44% |
4.44% |
| Packages |
297 |
297 |
| Duplicate Packages |
33 |
33 |
Bundle size by type 1 change 1 regression
| Current #5733 |
Baseline #5729 |
|
|---|---|---|
| JS |
9.39MiB (+0.01%) |
9.38MiB |
| Other |
144.28KiB |
144.28KiB |
Bundle analysis report Branch erik.emi2662-autoscroll-checkout Project dashboard
Generated by RelativeCI Documentation Report issue
- scroll completed step to top as it is completed - scroll active step to top if user is going backwards - scroll confirmation step to top if that is the active one
erikdstock
force-pushed
the
erik.emi2662-autoscroll-checkout
branch
from
15f6eed to
0e3fcb8
Compare
erikdstock
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of this PR is: FEAT
This PR solves EMI-2662
Description
This PR implements auto-scrolling in the checkout. It is mainly concerned with the mobile view:
In addition it scrolls into view the fulfillment details step if the user begins edits, adds or deletes an address.
Demonstration