Skip to content

feat: revamp Inquiry modal artwork card#16790

Merged
fladson merged 7 commits intomainfrom
TOP-109-changes-to-inquiry-modal-artwork-card
Feb 17, 2026
Merged

feat: revamp Inquiry modal artwork card#16790
fladson merged 7 commits intomainfrom
TOP-109-changes-to-inquiry-modal-artwork-card

Conversation

@fladson
Copy link
Copy Markdown
Contributor

@fladson fladson commented Feb 12, 2026

The type of this PR is: Feat

This PR solves TOP-109

Description

Acceptance Criteria:

  • Include the gallery name in the artwork information per design

  • Scale width of artwork thumbnail and crop out the overflow from the top and bottom

  • Truncate long artist names, artwork titles, and gallery names

  • No expandable view of artwork details on web

  • Expandable view of artwork details on mWeb

Screen.Recording.2026-02-12.at.17.15.21.mov

@artsy/topaz-devs

@fladson fladson requested a review from jpotts244 February 12, 2026 16:17
@fladson fladson self-assigned this Feb 12, 2026
olerichter00
olerichter00 previously approved these changes Feb 13, 2026
Copy link
Copy Markdown
Contributor

@olerichter00 olerichter00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟

Comment thread src/Components/Inquiry/Views/InquiryInquiry.tsx Outdated
Comment thread src/Components/Inquiry/Views/InquiryInquiry.tsx Outdated
</Box>
</Flex>
}
borderColor="transparent"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to get rid of the Expandable border.


const { dimensionsLabel } = useArtworkDimensions(artwork.dimensions)

const artworkDetailItems = [
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if force has a small component containing these details as its shown in a few places, is there an opportunity to not have it defined in multiple spots incase of drift?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't find it, but I can dig deeper. We have src/Apps/Artwork/Components/ArtworkDetails, but it contains more than what we need.

Co-authored-by: Ole <ole.richter91@gmail.com>
@relativeci
Copy link
Copy Markdown

relativeci Bot commented Feb 13, 2026

#6696 Bundle Size — 8.62MiB (+0.05%).

f3414e0(current) vs 2d2d98a main#6693(baseline)

Warning

Bundle contains 31 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#6696
     Baseline
#6693
No change  Initial JS 2.81MiB 2.81MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 15.67% 18.9%
No change  Chunks 110 110
No change  Assets 113 113
No change  Modules 5503 5503
No change  Duplicate Modules 615 615
No change  Duplicate Code 4.94% 4.94%
No change  Packages 250 250
No change  Duplicate Packages 30 30
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#6696
     Baseline
#6693
Regression  JS 8.47MiB (+0.05%) 8.47MiB
No change  Other 152.73KiB 152.73KiB

Bundle analysis reportBranch TOP-109-changes-to-inquiry-modal...Project dashboard


Generated by RelativeCIDocumentationReport issue

@fladson fladson merged commit 056bfa3 into main Feb 17, 2026
12 checks passed
@fladson fladson deleted the TOP-109-changes-to-inquiry-modal-artwork-card branch February 17, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants