Skip to content

Comments

refactor: simplify dev.Dockerfile#16850

Merged
mc-jones merged 3 commits intomainfrom
mc-jones/refactor-hokusai-dev
Feb 24, 2026
Merged

refactor: simplify dev.Dockerfile#16850
mc-jones merged 3 commits intomainfrom
mc-jones/refactor-hokusai-dev

Conversation

@mc-jones
Copy link
Contributor

The type of this PR is: refactor

Description

This PR makes a few docker related improvements:

  • It removes hokusai/templates/docker-compose-service-dev.yml.j2 and inlines the build configuration
  • t adds a yarn hokusai command for developer convenience
  • It removes unused docker ... commands from package.json
  • It renames Dockerfile.dev to dev.Dockerfile to match the more standard Dockerfile naming convention
  • It updates dev.Dockerfile to support yarn@v4

Related PR(s)

@mc-jones mc-jones requested a review from a team February 24, 2026 17:28
@mc-jones mc-jones self-assigned this Feb 24, 2026
@relativeci
Copy link

relativeci bot commented Feb 24, 2026

#6881 Bundle Size — 8.61MiB (-0.42%).

d04becd(current) vs e269d01 main#6879(baseline)

Warning

Bundle contains 31 duplicate packages – View duplicate packages

Bundle metrics  Change 5 changes Improvement 2 improvements
                 Current
#6881
     Baseline
#6879
Improvement  Initial JS 2.82MiB(-0.95%) 2.84MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 64.05% 0%
No change  Chunks 110 110
No change  Assets 113 113
Change  Modules 5499(-0.27%) 5514
Improvement  Duplicate Modules 615(-0.16%) 616
Change  Duplicate Code 4.94%(+0.41%) 4.92%
No change  Packages 250 250
No change  Duplicate Packages 30 30
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#6881
     Baseline
#6879
Improvement  JS 8.46MiB (-0.43%) 8.5MiB
Improvement  Other 152.73KiB (-0.01%) 152.75KiB

Bundle analysis reportBranch mc-jones/refactor-hokusai-devProject dashboard


Generated by RelativeCIDocumentationReport issue

@artsyit
Copy link
Contributor

artsyit commented Feb 24, 2026

Warnings
⚠️

Changes were made to package.json, but not to yarn.lock.
Perhaps you need to run yarn install?

Generated by 🚫 dangerJS against d04becd

@mc-jones mc-jones changed the title Mc jones/refactor hokusai dev refactor: simplify dev.Dockerfile Feb 24, 2026
@@ -1,4 +0,0 @@
image: "hokusai_force:${BUILD_TAG:-latest}"
Copy link
Contributor

@ovasdi ovasdi Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this image tag line left out on purpose? Im not sure exactly how this was being used within containerized development 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was removed on purpose to simplify it a bit. When both are specified and there is no pull_policy "Compose attempts to pull the image first and then builds from source if the image isn't found in the registry or platform cache" (ref). I think this is more relevant outside local dev and was cargo culted over form the original template.

@mc-jones mc-jones merged commit fd77cf1 into main Feb 24, 2026
13 of 14 checks passed
@mc-jones mc-jones deleted the mc-jones/refactor-hokusai-dev branch February 24, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants