Conversation
#6881 Bundle Size — 8.61MiB (-0.42%).d04becd(current) vs e269d01 main#6879(baseline) Warning Bundle contains 31 duplicate packages – View duplicate packages Bundle metrics
Bundle size by type
Bundle analysis report Branch mc-jones/refactor-hokusai-dev Project dashboard Generated by RelativeCI Documentation Report issue |
| @@ -1,4 +0,0 @@ | |||
| image: "hokusai_force:${BUILD_TAG:-latest}" | |||
There was a problem hiding this comment.
Was this image tag line left out on purpose? Im not sure exactly how this was being used within containerized development 🤔
There was a problem hiding this comment.
It was removed on purpose to simplify it a bit. When both are specified and there is no pull_policy "Compose attempts to pull the image first and then builds from source if the image isn't found in the registry or platform cache" (ref). I think this is more relevant outside local dev and was cargo culted over form the original template.
The type of this PR is: refactor
Description
This PR makes a few docker related improvements:
hokusai/templates/docker-compose-service-dev.yml.j2and inlines thebuildconfigurationyarn hokusaicommand for developer conveniencedocker ...commands frompackage.jsonDockerfile.devtodev.Dockerfileto match the more standardDockerfilenaming conventiondev.Dockerfileto supportyarn@v4Related PR(s)